Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @sbinet
So this PR has all the py.Context stuff wrapped into it minus:
On the
sync.CloseSync
issue you raised in the prev thread, the intention is to ensure that multiple holders of apy.Context
can all callClose()
without any (future) consequences. IMO, this is congruent with multiple holders of apy.Context
(and how it's annoying when ya have to ensure that only oneClose()
is called). People see that close code and they can feel comforted it's an interface ready for the real world. And it basically comes at no cost or allocations.The last commit on this PR should prevent any conflicts (assuming you merge PR 156 and 157 first)
Otherwise, lmk what you'd like to add/remove to this, otherwise I'll wait for this merge and then I'll immediately submit a PR with the above items rolled into a final PR or lmk what I should separate, etc. Thanks.