-
Notifications
You must be signed in to change notification settings - Fork 95
added examples and py utils #159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #159 +/- ##
==========================================
- Coverage 74.40% 72.96% -1.44%
==========================================
Files 66 70 +4
Lines 11395 11647 +252
==========================================
+ Hits 8478 8498 +20
- Misses 2351 2583 +232
Partials 566 566
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good.
but could we find a way to wire the examples into either a func ExampleXXX
or func TestXXX
scaffolding?
so everything is tested w/ go test ./...
?
(I guess func TestXXX
would be easier)
I had that thought as well. If I make the example's main optionally output to a file, in the TestXXX variant I could just compare that output against a known output as the test. How does that sound? |
yes, that, or have everything being compiled as part of the
|
How does this look? I'm not well versed in this sort of stuff, so lmk what I'm missing, thanks. |
@sbinet This works on my setup but it looks like I need help getting it work with CI here. |
it probably is coming from this:
|
Co-authored-by: Sebastien Binet <[email protected]>
Co-authored-by: Sebastien Binet <[email protected]>
Co-authored-by: Sebastien Binet <[email protected]>
Co-authored-by: Sebastien Binet <[email protected]>
Co-authored-by: Sebastien Binet <[email protected]>
Co-authored-by: Sebastien Binet <[email protected]>
Sigh, so I guess windows needed to be exe.exe? I test for windows at runtime and append an ".exe"? |
Co-authored-by: Sebastien Binet <[email protected]>
Co-authored-by: Sebastien Binet <[email protected]>
Co-authored-by: Sebastien Binet <[email protected]>
yay! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.