Skip to content

proper example completeness #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 13, 2022
Merged

proper example completeness #164

merged 2 commits into from
Feb 13, 2022

Conversation

drew-512
Copy link
Contributor

added proper py.Context.Close() for completeness and added as test for examples/embedding

@codecov
Copy link

codecov bot commented Feb 12, 2022

Codecov Report

Merging #164 (9b3b8be) into master (01cbebd) will increase coverage by 0.03%.
The diff coverage is 20.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #164      +/-   ##
==========================================
+ Coverage   72.86%   72.89%   +0.03%     
==========================================
  Files          71       71              
  Lines       11678    11682       +4     
==========================================
+ Hits         8509     8516       +7     
+ Misses       2600     2595       -5     
- Partials      569      571       +2     
Impacted Files Coverage Δ
examples/embedding/main.go 0.00% <0.00%> (ø)
examples/embedding/mylib.module.go 29.68% <0.00%> (-2.58%) ⬇️
main.go 15.62% <100.00%> (+2.72%) ⬆️
py/module.go 71.69% <0.00%> (ø)
modules/runtime.go 54.88% <0.00%> (+5.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01cbebd...9b3b8be. Read the comment docs.

@sbinet sbinet merged commit 232eb8e into go-python:master Feb 13, 2022
@drew-512 drew-512 deleted the improve-example-completeness branch February 17, 2022 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants