-
Notifications
You must be signed in to change notification settings - Fork 95
parser: Update from go tool yacc into goyacc #22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #22 +/- ##
==========================================
- Coverage 64.5% 64.43% -0.08%
==========================================
Files 55 55
Lines 9740 9793 +53
==========================================
+ Hits 6283 6310 +27
- Misses 3010 3036 +26
Partials 447 447
Continue to review full report at Codecov.
|
228e63a
to
9428ab9
Compare
Since Go 1.8 removed the go tool yacc command, we should update it to use goyacc
I am on a train + mobile, so I can't easily check... But is the piece of code you say should be tested, is tested within the same package? (There's probably a way to treat a whole repo like a single code-coverage unit so that parts of pkgA that are tested from pkgB still are counted as tested. But I haven't found it.) |
@sbinet |
I think that looks fine to me. I had a quick look through the auto generated code and it looks like it has just been tidied up. That may explain the code coverage oddities also since the line count of the generated code has increased. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
- Support auto-generated licence header based on created time. - Add missed case when adding testcases go-python#22
- Support auto-generated license header based on created time. - Add missed case when adding test cases go-python#22
- Support auto-generated license header based on created time. - Add missed case when adding test cases #22
Since Go 1.8 removed the go tool yacc command,
we should update it to use goyacc
reference: https://beta.golang.org/doc/go1.8#tool_yacc