-
Notifications
You must be signed in to change notification settings - Fork 95
py: Support zip builtin feature #45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #45 +/- ##
==========================================
+ Coverage 65.95% 66.01% +0.05%
==========================================
Files 57 58 +1
Lines 10208 10231 +23
==========================================
+ Hits 6733 6754 +21
- Misses 3002 3003 +1
- Partials 473 474 +1
Continue to review full report at Codecov.
|
@ncw Please take a look! Thanks alot! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that is looking very good!
A minor thing inline :-)
@ncw |
And always thank you for always giving me a kind review even though you are busy. |
That looks great now - thank you :-) |
Implement built-in
zip