Skip to content

py: Implement range M__getitem__ #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 3, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions py/range.go
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,24 @@ func RangeNew(metatype *Type, args Tuple, kwargs StringDict) (Object, error) {
}, nil
}

func (r *Range) M__getitem__(key Object) (Object, error) {
index, err := Index(key)
if err != nil {
return nil, err
}
// TODO(corona10): Support slice case
length := computeRangeLength(r.Start, r.Stop, r.Step)
if index < 0 {
index += length
}

if index < 0 || index >= length {
return nil, ExceptionNewf(TypeError, "range object index out of range")
}
result := computeItem(r, index)
return result, nil
}

// Make a range iterator from a range
func (r *Range) M__iter__() (Object, error) {
return &RangeIterator{
Expand Down Expand Up @@ -109,6 +127,12 @@ func (it *RangeIterator) M__next__() (Object, error) {
return r, nil
}

func computeItem(r *Range, item Int) Int {
incr := item * r.Step
res := r.Start + incr
return res
}

func computeRangeLength(start, stop, step Int) Int {
var lo, hi Int
if step > 0 {
Expand All @@ -129,5 +153,6 @@ func computeRangeLength(start, stop, step Int) Int {
}

// Check interface is satisfied
var _ I__getitem__ = (*Range)(nil)
var _ I__iter__ = (*Range)(nil)
var _ I_iterator = (*RangeIterator)(nil)
20 changes: 20 additions & 0 deletions py/tests/range.py
Original file line number Diff line number Diff line change
Expand Up @@ -18,4 +18,24 @@
assert len(a) == 100
assert len(b) == 100

doc="range_get_item"
a = range(3)
assert a[2] == 2
assert a[1] == 1
assert a[0] == 0
assert a[-1] == 2
assert a[-2] == 1
assert a[-3] == 0

b = range(0, 10, 2)
assert b[4] == 8
assert b[3] == 6
assert b[2] == 4
assert b[1] == 2
assert b[0] == 0
assert b[-4] == 2
assert b[-3] == 4
assert b[-2] == 6
assert b[-1] == 8

doc="finished"