Adding iterator method to Dict #59
Conversation
Codecov Report
@@ Coverage Diff @@
## master #59 +/- ##
==========================================
+ Coverage 67.94% 68.38% +0.44%
==========================================
Files 59 59
Lines 10378 10435 +57
==========================================
+ Hits 7051 7136 +85
+ Misses 2828 2794 -34
- Partials 499 505 +6
Continue to review full report at Codecov.
|
|
According to the coverage report your test doesn't hit your added code? |
|
The code is covered in |
py/tests/dict.py
Outdated
| @@ -12,4 +12,8 @@ | |||
| a = repr({"a":"b","c":5.5}) | |||
| assert a == "{'a': 'b', 'c': 5.5}" or a == "{'c': 5.5, 'a': 'b'}" | |||
|
|
|||
| doc="check __iter__" | |||
| a = {"a":"b","c":5.5} | |||
| assert "a" in a | |||
There was a problem hiding this comment.
Strictly speaking this test will no longer work when we implement the __contains__ method for dict.
Do can you change it to something like
l = list(iter(a))
assert "a" in l
assert "c" in l
assert len(l) == 2There was a problem hiding this comment.
This should be fixed now
|
That looks great now thank you! I see you added an items method too :-) Will merge now. |
Addresses #58