Skip to content

set: Implement __or__ of set #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 17, 2019
Merged

set: Implement __or__ of set #84

merged 2 commits into from
Sep 17, 2019

Conversation

DoDaek
Copy link
Contributor

@DoDaek DoDaek commented Sep 17, 2019

Implement or of set
ISSUE: #76

Copy link
Collaborator

@corona10 corona10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation is wrong

Expected

>>> a = {1,2,3}
>>> b = {4,5,6}
>>> a | b
{1, 2, 3, 4, 5, 6}
>>> 4 in a
False
>>>

Got

>>> a = {1,2,3}
>>> b = {4,5,6}
>>> a | b
<set instance at 0xc0003f8000>
>>> a
<set instance at 0xc0003f8000>
>>> 4 in a
True
>>>

@codecov-io
Copy link

Codecov Report

Merging #84 into master will increase coverage by 0.01%.
The diff coverage is 81.81%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #84      +/-   ##
==========================================
+ Coverage   68.83%   68.84%   +0.01%     
==========================================
  Files          59       59              
  Lines       10534    10545      +11     
==========================================
+ Hits         7251     7260       +9     
- Misses       2774     2775       +1     
- Partials      509      510       +1
Impacted Files Coverage Δ
py/set.go 37.64% <81.81%> (+6.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f7bb19...8cc9353. Read the comment docs.

Copy link
Collaborator

@corona10 corona10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@corona10 corona10 merged commit 261242c into go-python:master Sep 17, 2019
@DoDaek DoDaek deleted the issue-76 branch September 20, 2019 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants