Fix memory leak in GoImageProvider #74
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qt uses "implicit shared memory" for many of its types which is a scheme similar to copy on write, and is tracked by reference counting in the constructors/destructor of its classes. Unfortunately the imageprovider code creates an *QImage, which since it wasn't delete'd the destructor is not called, so when QML is done with its own copies, the shared image data can't be freed.
|
Should I also do a patch for v0 (master)? |
|
Any reason this was closed? The memory leak still exists in v1. |
|
That's awkward.. I don't think I had even seen this issue, despite the fact it marks me as having closed, and I would definitely not have closed it without a comment. |
|
Ahh.. this is just a really bad UI. It must have closed it automatically because I deleted the v1-dev branch. I cannot reopen it either. Can you please repropose against v1? |
|
I have re-done the patch for v1, I should be able to make a pull request for it quickly. |
|
Done #88. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Qt uses "implicit shared memory" for many of its types which is a scheme
similar to copy on write, and is tracked by reference counting in the
constructors/destructor of its classes.
Unfortunately the image provider code creates an *QImage, which since it
wasn't delete'd the destructor is not called, so when QML is done with its
own copies, the shared image data can't be freed.