fix: incorrectly set cookie's expires value in login.js#1049
Merged
fmartingr merged 1 commit intogo-shiori:masterfrom Jan 3, 2025
Merged
fix: incorrectly set cookie's expires value in login.js#1049fmartingr merged 1 commit intogo-shiori:masterfrom
fmartingr merged 1 commit intogo-shiori:masterfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1049 +/- ##
=======================================
Coverage 34.64% 34.64%
=======================================
Files 61 61
Lines 5499 5499
=======================================
Hits 1905 1905
Misses 3359 3359
Partials 235 235 ☔ View full report in Codecov by Sentry. |
fmartingr
approved these changes
Jan 3, 2025
Member
fmartingr
left a comment
There was a problem hiding this comment.
Hey @Promix953, thank you for taking your time and fixing this issue. Right now it looks good but later on I'm going to provide the ISO directly on the login/refresh APIs to keep that kind of logic out of the frontend. Thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When writing a cookie using document.cookie, the expires value should use the UTCString format.
https://developer.mozilla.org/en-US/docs/Web/API/Document/cookie#write_a_new_cookie
If expires is set incorrectly, the cookie will expire at the end of session and thumbnail will fail to load.