Skip to content

feat(apiv1): refactor tags api #1075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fmartingr merged 10 commits into from
Mar 11, 2025

test: use filepath.Join for path construction in bookmark tests

5af513c
Select commit
Loading
Failed to load commit list.
Merged

feat(apiv1): refactor tags api #1075

test: use filepath.Join for path construction in bookmark tests
5af513c
Select commit
Loading
Failed to load commit list.
This check has been archived and is scheduled for deletion. Learn more about checks retention
Codecov / codecov/project succeeded Mar 11, 2025 in 0s

49.14% (+8.07%) compared to cac1ba8

View this Pull Request on Codecov

49.14% (+8.07%) compared to cac1ba8

Details

Codecov Report

Attention: Patch coverage is 75.99376% with 308 lines in your changes missing coverage. Please review.

Project coverage is 49.14%. Comparing base (cac1ba8) to head (5af513c).

Files with missing lines Patch % Lines
internal/database/mysql.go 69.76% 92 Missing and 22 partials ⚠️
internal/database/pg.go 76.34% 60 Missing and 19 partials ⚠️
internal/database/sqlite.go 77.49% 60 Missing and 19 partials ⚠️
internal/http/handlers/api/v1/tags.go 84.94% 13 Missing and 1 partial ⚠️
internal/domains/tags.go 61.29% 9 Missing and 3 partials ⚠️
internal/http/handlers/api/v1/bookmarks.go 67.74% 8 Missing and 2 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1075      +/-   ##
==========================================
+ Coverage   41.06%   49.14%   +8.07%     
==========================================
  Files          70       71       +1     
  Lines        5929     6967    +1038     
==========================================
+ Hits         2435     3424     +989     
- Misses       3214     3221       +7     
- Partials      280      322      +42

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
View more details on Codecov