expose a few connection stats

[DaytonG]

My company currently uses go-stomp in a sidecar attached to a main service. We've seen some deadlocks during normal operation, and wanted to monitor a few internal states within go-stomp. This change adds a simple struct defining the sizes of the read and write channels in a Connection object, as well as a few super basic counters. Our software would periodically call Connection.Stats() and export the data to our metrics systems for further monitoring.

[DaytonG]

I moved this up because the go.mod also has 1.15. Figured that should match.

[worg]

Can we make the stat collection optional?

[DaytonG]

I can take out the counters, then the stats would have the main part I care about (the size of the channels), which would only ever be fetched on request. Would that be ok?

[worg]

I can take out the counters, then the stats would have the main part I care about (the size of the channels), which would only ever be fetched on request. Would that be ok?

yeah, that works, I'm not against the counters, my thinking is to have an internal boolean field in the Conn enabled via a WithStats functional option, so the count only happens for those that explicitly request them

[DaytonG]

Alrighty! In an effort to keep the counters in, I added a boolean around the increments