fix: bug where non-nil, empty dynamic variables are returned as an empty interface #1904
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreynering
approved these changes
Nov 4, 2024
pd93
added a commit
that referenced
this pull request
Nov 4, 2024
This was referenced Mar 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1903
This PR changes the
Shproperty of aVarto a pointer so that we are able to distinguish between a value that is not set (nil) and a value that is empty (&""). We then use this to return early if we detect an empty dynamic variable. This will always resolve to another empty string.This fixes cases where a dynamic variable contains a template that resolves to an empty string.