feat(test reports): development branch #1294
Conversation
* refactor(pipeline): use server API types for pipeline and migrate compiler types * gci * feat: add sender rule for pipelines --------- Co-authored-by: David May <[email protected]>
* chore(lint): address existing linter issues * remove dupl from exclusion list
* enhance(build): add fork field for OIDC * fix test * integration test update
* enhance(yaml): allow for users to parse pipelines using old library * testing file for internal yaml * chore(compiler): convert unmarshaled buildkite to go-yaml * remove tests used in later PRs * lintfix * fix schema * gci
…1230) Co-authored-by: David May <[email protected]>
Co-authored-by: david may <[email protected]>
* init commit * feat(repo): add pending approval timeout * fix test * remove dead code --------- Co-authored-by: David May <[email protected]>
…r have dupl anchors in map (#1232)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -0,0 +1,54 @@ | |||
| package pipeline | |||
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
Missed header for check (goheader)
| @@ -0,0 +1,29 @@ | |||
| package pipeline | |||
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
Missed header for check (goheader)
| // | ||
| // swagger:model PipelineTestReport | ||
| TestReport struct { | ||
| Results []string `yaml:"results,omitempty" json:"results,omitempty"` |
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
tag is not aligned, should be: yaml:"results,omitempty" json:"results,omitempty" (tagalign)
KellyMerrick
changed the title
…o test_feat_test_report
…o test_feat_test_report
…o test_feat_test_report
…o test_feat_test_report
| ErrEmptyFileType = errors.New("empty file_type provided") | ||
| // ErrEmptyPresignedUrl defines the error type when a | ||
| // TestReportAttachment type has an empty PresignedUrl field provided. | ||
| ErrEmptyPresignedUrl = errors.New("empty presigned_url provided") |
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
var-naming: var ErrEmptyPresignedUrl should be ErrEmptyPresignedURL (revive)
| ObjectPath sql.NullString `sql:"object_path"` | ||
| FileSize sql.NullInt64 `sql:"file_size"` | ||
| FileType sql.NullString `sql:"file_type"` | ||
| PresignedUrl sql.NullString `sql:"presigned_url"` |
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
var-naming: struct field PresignedUrl should be PresignedURL (revive)
| @@ -0,0 +1,50 @@ | |||
| package buildkite | |||
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
Missed header for check (goheader)
| ObjectPath *string `json:"object_path,omitempty"` | ||
| FileSize *int64 `json:"file_size,omitempty"` | ||
| FileType *string `json:"file_type,omitempty"` | ||
| PresignedUrl *string `json:"presigned_url,omitempty"` |
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
var-naming: struct field PresignedUrl should be PresignedURL (revive)
| import ( | ||
| "context" | ||
| "fmt" | ||
| "github.com/urfave/cli/v3" |
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
File is not properly formatted (gci)
| // | ||
| // When the provided TestAttachment type is nil, or the field within | ||
| // the type is nil, it returns the zero value for the field. | ||
| func (r *TestAttachment) GetPresignedUrl() string { |
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
var-naming: method GetPresignedUrl should be GetPresignedURL (revive)
| } | ||
|
|
||
| // SetPresignedUrl sets the PresignedUrl field. | ||
| func (r *TestAttachment) SetPresignedUrl(v string) { |
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
var-naming: method SetPresignedUrl should be SetPresignedURL (revive)
| @@ -108,7 +108,9 @@ | |||
|
|
|||
| if len(step.Commands) == 0 && len(step.Environment) == 0 && | |||
| len(step.Parameters) == 0 && len(step.Secrets) == 0 && | |||
| len(step.Template.Name) == 0 && !step.Detach { | |||
| len(step.Template.Name) == 0 && len(step.TestReport.Results) == 0 && | |||
| len(step.TestReport.Attachments) == 0 && !step.Detach { | |||
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
unnecessary leading newline (whitespace)
| @@ -77,5 +77,6 @@ | |||
| return nil, fmt.Errorf("unable to create indexes for %s table: %w", constants.TableBuild, err) | |||
| } | |||
|
|
|||
| //nolint:revive // ignore returning unexported engine | |||
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
directive //nolint:revive // ignore returning unexported engine is unused for linter "revive" (nolintlint)
| @@ -77,5 +77,6 @@ func New(opts ...EngineOpt) (*Engine, error) { | |||
| return nil, fmt.Errorf("unable to create indexes for %s table: %w", constants.TableHook, err) | |||
| } | |||
|
|
|||
| //nolint:revive // ignore returning unexported engine | |||
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
directive //nolint:revive // ignore returning unexported engine is unused for linter "revive" (nolintlint)
This branch is the combined working branch for development purposes, but will be closed in lieu of separate pr's (currently in draft) when ready, to allow for smaller pr's: