This repository was archived by the owner on Sep 7, 2021. It is now read-only.
This repository is currently being migrated. It's locked while the migration is in progress.
Fix mssql issue with duplicate columns.#1225
Open
Neopallium wants to merge 2 commits into
Open
Conversation
The `GetColumns()` method for the mssql dialect can return the same column multiple times if the column is in multiple indexes.
Codecov Report
@@ Coverage Diff @@
## master #1225 +/- ##
=========================================
+ Coverage 57.35% 57.4% +0.04%
=========================================
Files 43 43
Lines 7797 7794 -3
=========================================
+ Hits 4472 4474 +2
+ Misses 2771 2769 -2
+ Partials 554 551 -3
Continue to review full report at Codecov.
|
Member
|
Thanks @Neopallium . Could you write some test cases for these changes? |
mei-rune
pushed a commit
to mei-rune/xorm
that referenced
this pull request
Apr 19, 2020
fix test fix test Fix mssql issue with duplicate columns. The `GetColumns()` method for the mssql dialect can return the same column multiple times if the column is in multiple indexes. Co-authored-by: Robert G. Jakabosky <bobby@sharedrealm.com> Reviewed-on: https://gitea.com/xorm/xorm/pulls/1225
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
GetColumns()method for the mssql dialect can return the samecolumn multiple times if the column is in multiple indexes.