Skip to content

[fix] Added null check for page and size before making callback #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 28, 2024
Merged

[fix] Added null check for page and size before making callback #1

merged 1 commit into from
Nov 28, 2024

Conversation

ArjunChouksey95
Copy link

Added null Check for page and size to avoid running on null or undefined errors.
Intentions for doing this. -> Jira Ticket

@ArjunChouksey95 ArjunChouksey95 added the bug Something isn't working label Nov 27, 2024
abhaga
abhaga approved these changes Nov 28, 2024
View reviewed changes
Copy link

@abhaga abhaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Were the files under dist/ generated by building the project or are we manually patching them? Ideally they should be built. Not sure if some checksum somewhere might cause issue with manually patching them.

@ArjunChouksey95 ArjunChouksey95 merged commit 7d29bce into master Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhaga abhaga abhaga approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ArjunChouksey95 @abhaga