Skip to content

sources/kerberos: update to new python-kadmin-rs#19491

Merged
rissson merged 3 commits into
mainfrom
update-kadmin
Jan 16, 2026
Merged

sources/kerberos: update to new python-kadmin-rs#19491
rissson merged 3 commits into
mainfrom
update-kadmin

Conversation

@rissson

@rissson rissson commented Jan 15, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Details

Closes #17862

Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make docs)

@rissson
sources/kerberos: update to new python-kadmin-rs
db61e3c 
Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
@rissson rissson self-assigned this Jan 15, 2026
@rissson rissson requested a review from a team as a code owner January 15, 2026 17:50
@rissson rissson added the backport/version-2025.12 Add this label to PRs to backport changes to version-2025.12 label Jan 15, 2026
@rissson rissson requested a review from a team as a code owner January 15, 2026 17:50
@rissson
also update frontend
35af484 
Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
@rissson rissson requested a review from a team as a code owner January 15, 2026 17:50
@netlify

netlify Bot commented Jan 15, 2026

Copy link
Copy Markdown

✅ Deploy Preview for authentik-storybook ready!

Name Link
🔨 Latest commit db61e3c
🔍 Latest deploy log https://app.netlify.com/projects/authentik-storybook/deploys/696928e77495320008cf5656
😎 Deploy Preview https://deploy-preview-19491--authentik-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify

netlify Bot commented Jan 15, 2026 •
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for authentik-integrations ready!

Name Link
🔨 Latest commit c8d0ef5
🔍 Latest deploy log https://app.netlify.com/projects/authentik-integrations/deploys/69692ed4503d9d0008310b6e
😎 Deploy Preview https://deploy-preview-19491--authentik-integrations.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify

netlify Bot commented Jan 15, 2026

Copy link
Copy Markdown

✅ Deploy Preview for authentik-docs ready!

Name Link
🔨 Latest commit db61e3c
🔍 Latest deploy log https://app.netlify.com/projects/authentik-docs/deploys/696928e700dd1d0008360510
😎 Deploy Preview https://deploy-preview-19491--authentik-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify

netlify Bot commented Jan 15, 2026 •
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for authentik-docs ready!

Name Link
🔨 Latest commit c8d0ef5
🔍 Latest deploy log https://app.netlify.com/projects/authentik-docs/deploys/69692ed48bf847000843943b
😎 Deploy Preview https://deploy-preview-19491--authentik-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@rissson rissson enabled auto-merge (squash) January 15, 2026 17:53
@netlify

netlify Bot commented Jan 15, 2026 •
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for authentik-storybook ready!

Name Link
🔨 Latest commit c8d0ef5
🔍 Latest deploy log https://app.netlify.com/projects/authentik-storybook/deploys/69692ed4c63da10008c750de
😎 Deploy Preview https://deploy-preview-19491--authentik-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov

codecov Bot commented Jan 15, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 66.66667% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 93.27%. Comparing base (2c29698) to head (c8d0ef5).
⚠️ Report is 6 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
authentik/sources/kerberos/models.py 70.00% 3 Missing ⚠️
authentik/sources/kerberos/signals.py 50.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #19491      +/-   ##
==========================================
+ Coverage   93.03%   93.27%   +0.23%     
==========================================
  Files         949      949              
  Lines       52052    52052              
==========================================
+ Hits        48428    48550     +122     
+ Misses       3624     3502     -122
Flag Coverage Δ
conformance 38.27% <41.66%> (ø)
e2e 44.21% <41.66%> (+1.02%) ⬆️
integration 23.20% <41.66%> (ø)
unit 91.50% <66.66%> (+0.01%) ⬆️
unit-migrate 91.52% <66.66%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

kensternberg-authentik
kensternberg-authentik approved these changes Jan 15, 2026
View reviewed changes

@kensternberg-authentik kensternberg-authentik left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks simple enough. :-)

@github-actions

github-actions Bot commented Jan 15, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-c8d0ef5dcc389b79d252d5cfd7030a6911319878
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
    image:
        repository: ghcr.io/goauthentik/dev-server
        tag: gh-c8d0ef5dcc389b79d252d5cfd7030a6911319878

Afterwards, run the upgrade commands from the latest release notes.

melizeche
melizeche reviewed Jan 15, 2026
View reviewed changes
Comment thread authentik/sources/kerberos/migrations/0005_alter_kerberossource_kadmin_type.py
Comment on lines +21 to +29
operations = [
migrations.RunPython(migrate_kadmin_type, reverse_code=migrations.RunPython.noop),
migrations.AlterField(
model_name="kerberossource",
name="kadmin_type",
field=models.TextField(
choices=[("MIT", "Mit"), ("Heimdal", "Heimdal")],
default="MIT",
help_text="KAdmin server type",

@melizeche melizeche Jan 15, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So users that had configured "Other" will be changed to MIT?
Are any unexpected behavior or changes that we need to document?

@rissson rissson Jan 16, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nah, other and Heimdal never even worked before, so I wouldn't worry about it

@rissson rissson merged commit ee8b3e3 into main Jan 16, 2026
100 of 101 checks passed
@github-project-automation github-project-automation Bot moved this from Todo to In Progress in authentik Core Jan 16, 2026
@rissson rissson deleted the update-kadmin branch January 16, 2026 11:35
@github-project-automation github-project-automation Bot moved this from In Progress to Done in authentik Core Jan 16, 2026
authentik-automation Bot pushed a commit that referenced this pull request Jan 16, 2026
@rissson @authentik-automation
Cherry-pick #19491 to version-2025.12 (with conflicts)
46fc1cd 
This cherry-pick has conflicts that need manual resolution.

Original PR: #19491
Original commit: ee8b3e3
@authentik-automation authentik-automation Bot mentioned this pull request Jan 16, 2026
Merged
@authentik-automation

authentik-automation Bot commented Jan 16, 2026

Copy link
Copy Markdown
Contributor

⚠️ Cherry-pick to version-2025.12 has conflicts: #19523

rissson added a commit that referenced this pull request Jan 16, 2026
@authentik-automation @rissson
sources/kerberos: update to new python-kadmin-rs (cherry-pick #19491 …
502e037 
…to version-2025.12) (#19523)

Co-authored-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@melizeche melizeche melizeche left review comments
@BeryJu BeryJu BeryJu approved these changes
@kensternberg-authentik kensternberg-authentik kensternberg-authentik approved these changes

Assignees

@rissson rissson

Labels

area:backend backport/version-2025.12 Add this label to PRs to backport changes to version-2025.12

Projects

authentik Core
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rissson @melizeche @BeryJu @kensternberg-authentik