Skip to content

web/forms: fix invalid date error for empty datetime-local inputs (cherry-pick #19561 to version-2025.12) #19582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BeryJu merged 1 commit into from
Jan 20, 2026
Merged

web/forms: fix invalid date error for empty datetime-local inputs (cherry-pick #19561 to version-2025.12) #19582

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions web/src/elements/forms/Form.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,17 +114,23 @@ export function serializeForm<T = Record<string, unknown>>(elements: Iterable<AK
}

if (inputElement.type === "datetime-local") {
const valueAsNumber = inputElement.valueAsNumber;
return assignValue(
inputElement,
dateToUTC(new Date(inputElement.valueAsNumber)),
isNaN(valueAsNumber) ? null : dateToUTC(new Date(valueAsNumber)),
json,
);
}

if ("type" in inputElement.dataset && inputElement.dataset.type === "datetime-local") {
// Workaround for Firefox <93, since 92 and older don't support
// datetime-local fields
return assignValue(inputElement, dateToUTC(new Date(inputElement.value)), json);
const date = new Date(inputElement.value);
return assignValue(
inputElement,
isNaN(date.getTime()) ? null : dateToUTC(date),
json,
);
}

if (inputElement.type === "checkbox") {
Expand Down
Loading