Skip to content

core: fix non-expiring service accounts and app passwords (cherry-pick #19913 to version-2025.12) #19941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
melizeche merged 1 commit into from
Feb 2, 2026
Merged

core: fix non-expiring service accounts and app passwords (cherry-pick #19913 to version-2025.12) #19941

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion authentik/core/api/tokens.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,8 @@ def validate(self, attrs: dict[Any, str]) -> dict[Any, str]:
except ValueError:
pass

if "expires" in attrs and attrs.get("expires") > max_token_lifetime_dt:
expires = attrs.get("expires")
if expires is not None and expires > max_token_lifetime_dt:
raise ValidationError(
{
"expires": (
Expand Down
4 changes: 2 additions & 2 deletions web/src/elements/forms/Form.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ export function serializeForm<T = Record<string, unknown>>(elements: Iterable<AK
const valueAsNumber = inputElement.valueAsNumber;
return assignValue(
inputElement,
isNaN(valueAsNumber) ? null : dateToUTC(new Date(valueAsNumber)),
isNaN(valueAsNumber) ? undefined : dateToUTC(new Date(valueAsNumber)),
json,
);
}
Expand All @@ -128,7 +128,7 @@ export function serializeForm<T = Record<string, unknown>>(elements: Iterable<AK
const date = new Date(inputElement.value);
return assignValue(
inputElement,
isNaN(date.getTime()) ? null : dateToUTC(date),
isNaN(date.getTime()) ? undefined : dateToUTC(date),
json,
);
}
Expand Down
Loading