-
-
Notifications
You must be signed in to change notification settings - Fork 253
Closed
Labels
bugSomething isn't workingSomething isn't working
Description
If I use something like WHERE id in (?)
and HAVING count(id) = ?
at the same time, it does not compiled expectedly.
The line below is called if there is in (?)
on SQL which is built by buildSelectSQL()
, but there is another ?
for HAVING
and sqlx.In()
returns error "number of bindVars exceeds arguments". (I cannot sure since I just checked it on pop
code and did not get into sqlx
code anyway.)
Line 59 in 8d249c6
s, _, err := sqlx.In(sq.sql, sq.Args()) |
IMHO, we can move this lines into buildWhereClauses()
. Can I open a PR for this?
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't working