remove unnecessary goto #212
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This goto statement is important for improvement performance. Please try to run benchmark |
|
I checked it in linux and windows, result same, tiny improvements with loop. |
|
@goccy |
goccy
requested changes
May 5, 2021
|
I'm planning to do the refactoring after this, so I don't need to create a PR at this stage. |
Codecov Report
@@ Coverage Diff @@
## master #212 +/- ##
==========================================
+ Coverage 82.12% 82.15% +0.02%
==========================================
Files 49 49
Lines 21765 21768 +3
==========================================
+ Hits 17875 17883 +8
+ Misses 3026 3021 -5
Partials 864 864 |
goccy
approved these changes
May 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
go version go1.16 linux/amd64gotois not needed insideskipWhiteSpace