Skip to content

Conversation

goccy
Copy link
Owner

@goccy goccy commented Jun 12, 2021

fix #247

fix indent number and totalLength for recursive type .

Benchmark result

After fixed, I tried to run benchmark was introduced in #247

goos: darwin
goarch: amd64
pkg: benchmark
BenchmarkMarshalIndentEncodingJson-16         24284             48370 ns/op          105041 B/op         25 allocs/op
BenchmarkMarshalIndentGoJson-16              120224              9335 ns/op           22512 B/op         22 allocs/op

@codecov-commenter
Copy link

Codecov Report

Merging #249 (b972a9b) into master (ad04977) will increase coverage by 0.08%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #249      +/-   ##
==========================================
+ Coverage   81.50%   81.59%   +0.08%     
==========================================
  Files          46       46              
  Lines       14537    14537              
==========================================
+ Hits        11848    11861      +13     
+ Misses       2142     2134       -8     
+ Partials      547      542       -5     

@cwbriscoe
Copy link

Nice work. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MarshalIndent very slow and ends up getting killed by OS on large files or when benchmarking
3 participants