fix: fixed invalid utf8 on stream decoder #279
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #279 +/- ##
=======================================
Coverage 81.32% 81.32%
=======================================
Files 47 47
Lines 15523 15529 +6
=======================================
+ Hits 12624 12629 +5
- Misses 2339 2340 +1
Partials 560 560 |
|
Thank you for the great PR ! LGTM ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The go-json stream decoder has a buffer, but it may keep the end as utf8 which is not correct.
If you decode it as a string, it will be regarded as RuneError.
If the length is not long enough, you need to read it additionally from the reader.
I fixed the problem.