Skip to content

Conversation

@chief-micco
Copy link
Contributor

To help us get this pull request reviewed and merged quickly, please be sure to include the following items:

  • Tests (if applicable)
  • Documentation (if applicable)
  • Changelog entry
  • A full explanation here in the PR description of the work done

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

Backward Compatibility

Is this change backward compatible with the most recently released version? Does it introduce changes which might change the user experience in any way? Does it alter the API in any way?

  • Yes (backward compatible)
  • No (breaking changes)

What's new?

  • Support for dotnet 10.
  • Updated targetframework elements to include net10.0
  • Updated build scripts to install and use dotnet 10 SDK
  • Updated samples to be dotnet 10
  • Updated some other nuget packages to newer versions

- Add net10.0 target framework to all library projects (AppEncryption, Crypto, Logging, SecureMemory, PlatformNative)
- Update all test projects to target net10.0
- Update SecureMemory NuGet packages to latest versions:
  - Microsoft.Extensions.* packages: 9.0.10 -> 10.0.0
  - JunitXml.TestLogger: 6.1.0 -> 7.0.2
  - Microsoft.NET.Test.Sdk: 17.14.1 -> 18.0.1
  - xunit.runner.visualstudio: 3.1.3 -> 3.1.5
- Remove unnecessary package references (System.Net.Http, System.Text.RegularExpressions, System.Diagnostics.Debug, System.Runtime.InteropServices, System.Threading)
- Remove unnecessary package references from AppEncryption.Tests (System.Net.Http, System.Net.Security, System.Text.RegularExpressions)
- Suppress CA1873 warnings in AppEncryption and AppEncryption.IntegrationTests projects
  (CA1873 is a new .NET 10.0 analyzer rule for expensive logging argument evaluation)
- Update sample projects to target net10.0:
  - samples/csharp/aws/ecs/myapp/myapp.csproj
  - samples/csharp/ReferenceApp/ReferenceApp/ReferenceApp.csproj
  - tests/cross-language/csharp/Cltf.csproj

- Update all NuGet packages to latest versions:
  - AppEncryption: AWS SDK, Microsoft.Extensions.* (9.0.8 -> 10.0.0), Newtonsoft.Json, System.Text.*
  - AppEncryption.Tests: AWS SDK, JunitXml.TestLogger (6.1.0 -> 7.0.2), Microsoft.NET.Test.Sdk (17.14.1 -> 18.0.1), Testcontainers, MySql.Data (9.4.0 -> 9.5.0), xunit.runner.visualstudio
  - AppEncryption.IntegrationTests: AWS SDK, Microsoft.NET.Test.Sdk, MySql.Data, xunit.runner.visualstudio
  - Crypto: System.Text.* packages (9.0.8 -> 10.0.0)
  - Logging: Microsoft.Extensions.Logging (9.0.10 -> 10.0.0)
  - Logging.Tests: JunitXml.TestLogger, Microsoft.NET.Test.Sdk, xunit.v3 (3.0.1 -> 3.2.0), xunit.runner.visualstudio
  - Samples: GoDaddy.Asherah.AppEncryption (0.7.0 -> 0.8.0), Microsoft.Extensions.Logging.Console, MySql.Data
  - Cltf: SpecFlow (3.1.97 -> 3.9.74), xunit (2.4.1 -> 2.9.3), Microsoft.NET.Test.Sdk (16.5.0 -> 18.0.1), MySql.Data
- Update all GitHub workflow files to use .NET 10.0:
  - Container images: mcr.microsoft.com/dotnet/sdk:9.0 -> 10.0
  - setup-dotnet versions: 9.0.x -> 10.0.x
  - Updated workflows: csharp-pr, csharp-appencryption-*, csharp-securememory-*, csharp-logging-*, cross-language-validation

- Update Docker files:
  - samples/csharp/aws/ecs/myapp/Dockerfile: Update SDK and runtime images from 9.0 to 10.0
  - samples/csharp/aws/ecs/README.md: Update documentation to reference .NET SDK 10.0
@aka-bo aka-bo merged commit e2683ad into godaddy:main Nov 13, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants