[cicd] golangci-lint upgrade to v2 #1595
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated GitHub Actions workflows to use golangci-lint-action v7.0.1 with golangci-lint v2.8.0. Migrated all 5 .golangci.yml configuration files from v1 to v2 format using the built-in migrate command. Updated CLAUDE.md with binary installation instructions synced to CI version. Changes: - Workflows: Updated to [email protected] with v2.8.0 - Configs: Migrated 5 files to v2 format (version: "2" header added) - go/appencryption/.golangci.yml - go/securememory/.golangci.yml - server/go/.golangci.yml - samples/go/referenceapp/.golangci.yml - tests/cross-language/go/.golangci.yml - Documentation: Updated with binary installation method - Removed: install-mode parameter (binary is default in v7) All configs validated successfully and local linting tested on key modules.
Simplified embedded field access in test file by removing explicit secretInternal reference. Since secretInternal is embedded in secret, its fields can be accessed directly. Fixed: - sec.secretInternal.bytes → sec.bytes (2 occurrences) All golangci-lint checks now pass for securememory package.
Fixed: - session_cache_test.go: Simplified embedded field access and optimized fmt.Fprintf usage (QF1008, QF1012) Added exclusions: - prealloc: Excluded for test files and memory.go (minimal benefit) - gosmopolitan: Excluded for test files (intentional Unicode test data) - ST1012: Excluded error naming convention (breaking API change for v2 plugin) All golangci-lint checks now pass for appencryption package.
Removed build/go/lint.sh and all symlinks to it across Go modules. These local lint scripts are no longer needed as linting is now handled directly by the golangci-lint-action in CI workflows.
Excluded noctx linter warnings for main.go and database.go where context is not meaningful: - main.go:57 - net.Listen() during server startup (no request context) - database.go:46 - DB.Exec() for session configuration during init Both violations are in initialization/setup code where using context would be ceremonial without providing actual cancellation/timeout benefits. All golangci-lint checks now pass for server/go package.
sushantmimani
approved these changes
Jan 12, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To help us get this pull request reviewed and merged quickly, please be sure to include the following items:
PR Type
What kind of change does this PR introduce?
Backward Compatibility
Is this change backward compatible with the most recently released version? Does it introduce changes which might change the user experience in any way? Does it alter the API in any way?
What's new?
Migrates from golangci-lint v1.64.2 to v2.8.0 to address Go version compatibility issues.
Changes
[email protected]with v2.8.0 binary installation.golangci.ymlfiles to v2 format withversion: "2"headerbuild/go/lint.shand symlinksCLAUDE.mdwith v2 binary installation instructions