Fix MSVC warning for potential mod by 0 (C4724)

[nukethebees]

With dev_mode=yes, MSVC warns that some modulo expressions may be x % 0 and refuses to compile.

By assigning the size variables to local variables, the compiler knows size > 0 if the loop bodies are entered. Without the local variable, it's technically possible for size() to become zero after entering the body.

https://learn.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-3-c4724?view=msvc-170

[nukethebees]

I'm adding static casts to int to fix the failing builds. Will commit soon.

[akien-mga]

Vector::size returns int64_t, I don't think you need an explicit cast here. We usually just use sizes like this:

const int size = vector.size();

[nukethebees]

Vector::size returns int64_t, I don't think you need an explicit cast here. We usually just use sizes like this:

const int size = vector.size();

Sorry, I didn't read the return type closely enough. I'm used to container size types always being unsigned e.g. std::size_t.

Either way, the original usage of uint64_t was wrong and the current cast makes the implicit conversion explicit. I'll fix the incorrect commit message.

[akien-mga]

We don't usually use explicit static casts in such cases. Our consensus is that it makes code harder to read and doesn't add much value.

[nukethebees]

We don't usually use explicit static casts in such cases. Our consensus is that it makes code harder to read and doesn't add much value.

Should I remove the casts or just leave them?

[akien-mga]

I would just use const int points_size = points.size(); if it works.

[akien-mga]

Looks good! Could you squash the commits? See PR workflow for instructions.

[akien-mga]

Thanks! And congrats for your first merged Godot contribution 🎉

[Zylann]

So the strange thing is, now my Godot 4.4.1-stable builds are failing with that exact error, warning C4724: potential mod by 0 in cowdata, I wonder what happened because my builds were working before, and now they don't, despite the fact I havent changed the Godot version my module compiles with.

[akien-mga]

Most likely the GitHub Actions runner for Windows was updated to a newer version of MSVC which triggers this warning. @nukethebees might have been running a preview or just a more up-to-date version than GHA a month ago.

[aaronfranke]

There were conflicts when backporting this to Godot 4.3, so I opened PR #108321 to manually backport it.

However, this PR can be automatically cherry-picked for Godot 4.4.