Skip to content

Editor: Add classic text search functionality to Output panel #107148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yangyey
Copy link
Contributor

@yangyey yangyey commented Jun 5, 2025

Implements classic search in the Output (EditorLog) panel, including:

  • Search box with toggles for "Match Case" and "Whole Words"
  • Navigation buttons for next/previous match
  • Highlights matches, with distinction for the currently selected
  • Scroll to active match when navigating

This improves usability for developers debugging or scanning log output by allowing quick and flexible keyword searching. This looks to implement what was referenced in godot-proposals features godotengine/godot-proposals#12074 and godotengine/godot-proposals#10249.

Co-authored-by: @SunChenWei

dier diyi

@AThousandShips AThousandShips requested a review from a team June 5, 2025 12:02
@AThousandShips AThousandShips added this to the 4.x milestone Jun 5, 2025
@yangyey yangyey closed this Jun 5, 2025
@yangyey yangyey reopened this Jun 5, 2025
@arkology
Copy link
Contributor

arkology commented Jun 5, 2025

Note that search icon is broken:

451862641-8a002d13-9bea-4582-9f7f-e619e85c9a81

Not sure about UI and shortcuts, but this is definitely usability improvement for output dock.

@yangyey
Copy link
Contributor Author

yangyey commented Jun 5, 2025

Note that search icon is broken:

451862641-8a002d13-9bea-4582-9f7f-e619e85c9a81

Not sure about UI and shortcuts, but this is definitely usability improvement for output dock.

Yes, thanks for pointing out. I accidentally deleted the line that made that icon, now it should fixed.

@KoBeWi
Copy link
Member

KoBeWi commented Jun 18, 2025

Match label can push the buttons to the right:

godot.windows.editor.dev.x86_64_KOeCFOHGd7.mp4

It would be better to avoid that. Compare with script editor's search:

godot.windows.editor.dev.x86_64_XfOv2bO0oZ.mp4

Also there are some text differences, and the strings don't get translated. It would be better to make them consistent.

@yangyey
Copy link
Contributor Author

yangyey commented Jun 19, 2025

Match label can push the buttons to the right:

godot.windows.editor.dev.x86_64_KOeCFOHGd7.mp4
It would be better to avoid that. Compare with script editor's search:

godot.windows.editor.dev.x86_64_XfOv2bO0oZ.mp4
Also there are some text differences, and the strings don't get translated. It would be better to make them consistent.

I see, some text were not coherent with the text in the editor therefore not being translated, and there are two strings that would need addtions to the translation documentation ( "Switch to Filter Mode" and "Switch to Search Mode"). Regarding the pushing to the right, this was happening because there isn't anything more on the left ( in editor in squeezes the input box to the left instead), so the way to solve this would be to move the checkboxes to the right. I'll make an update.
Captura de ecrã 2025-06-19 064023

Implements classic search in the Output (EditorLog) panel, including:
- Search box with toggles for "Match Case" and "Whole Words"
- Navigation buttons for next/previous match
- Highlights matches, with distinction for the currently selected
- Scroll to active match when navigating

This improves usability for developers debugging or scanning log
output by allowing quick and flexible keyword searching.
This looks to implement what was referenced in godot-proposals
features  godotengine#12074 and godotengine#10249.
Co-authored-by: Sun Chenwei <[email protected]>

fix: re-added a line that was deleted by accident

fix : inconsistent text and unwanted checkbox being pushed off to the right.
@AThousandShips AThousandShips changed the title editor: Add classic text search functionality to Output panel Editor: Add classic text search functionality to Output panel Jun 19, 2025
@KoBeWi
Copy link
Member

KoBeWi commented Jun 19, 2025

the way to solve this would be to move the checkboxes to the right.

You could also experiment with adding some spacing Control node.

@yangyey
Copy link
Contributor Author

yangyey commented Jun 19, 2025

the way to solve this would be to move the checkboxes to the right.

You could also experiment with adding some spacing Control node.

Yes that's what I decided to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants