Fix PROPERTY_HINT_GROUP_ENABLE display on hover
#108264
Open
+22
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lodetrick
force-pushed
the
group-enable-hover
branch
from
a01590b to
b1ccac7
Compare
KoBeWi
reviewed
Jul 5, 2025
| @@ -2166,11 +2168,11 @@ void EditorInspectorSection::setup(const String &p_section, const String &p_labe | |||
|
|
|||
| void EditorInspectorSection::gui_input(const Ref<InputEvent> &p_event) { | |||
| ERR_FAIL_COND(p_event.is_null()); | |||
| bool has_children_to_show = vbox->get_child_count(false) != 0; | |||
| bool can_click_unfold = vbox->get_child_count(false) != 0 && !(!checkbox_only && checkable && !checked); | |||
There was a problem hiding this comment.
Uh, double negation. I think the condition can be something like
Suggested change
| bool can_click_unfold = vbox->get_child_count(false) != 0 && !(!checkbox_only && checkable && !checked); | |
| bool can_click_unfold = vbox->get_child_count(false) != 0 && (checkbox_only || !checkable || checked); |
Though it's arguable which one is more readable.
There was a problem hiding this comment.
In my opinion the double negation is more readable because it is checking against a single case (is how I thought about it), I reorganized it which made the double negation more apparent, I could change it back to:
Suggested change
| bool can_click_unfold = vbox->get_child_count(false) != 0 && !(!checkbox_only && checkable && !checked); | |
| bool can_click_unfold = vbox->get_child_count(false) != 0 && !(checkable && !checked && !checkbox_only); |
KoBeWi
reviewed
Jul 5, 2025
KoBeWi
approved these changes
Jul 5, 2025
lodetrick
force-pushed
the
group-enable-hover
branch
from
b1ccac7 to
e9c5c71
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #108257
This PR fixes a regression by making it so unchecked sections do not show the hovered highlight. This PR syncs the
gui_input()'s understanding of the hover with theNOTIFICATION_DRAW, as there were issues with the hover hint becoming out of sync.