Use different blend func on Mobile for Multiply #108849
Open
+14
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #96961
(Issue marked for documentation but since a fix is possible I consider this to be a bugfix.)
Title. On forward mobile color values are effectively halved during the blending stage (pure white is 0.5). Due to this, attachments with blend factors involving colors won't look correct. Luckily, in the case of the basic Multiply blend mode, the output can be doubled by multiplying on both sides of the function.
0.5 grey on top of icon (Remember to set tonemap to linear when testing):
Added comment for future so this patchwork can be removed if the behavior changes. (Which would be necessary for implementing any new blend modes, other than min, max or inverse subtract.)