Refactor EditorToaster, adding a Toast class and Actions#117700
Refactor EditorToaster, adding a Toast class and Actions#117700jaydensipe wants to merge 1 commit intogodotengine:masterfrom
EditorToaster, adding a Toast class and Actions#117700Conversation
2e2237c to
3681807
Compare
Fixed for now, but I do want the toast to support autowrap, instead of just cutting off the text.
Fixed, has a slightly ugly border when progress goes down, will fix soon.
Done! |
3681807 to
ddb887d
Compare
a334618 to
fc54268
Compare
|
@AThousandShips Yo, thanks for the review, applied all changes! Also just curious, what is the rationale behind PRs behind marked as |
|
You changed the return argument of the method, this isn't a critical change of compat but it's still relevant to flag |
fc54268 to
769d06d
Compare
|
Code-wise this is pretty much done now I'd say. Now just waiting on review to write documentation and to see if this is the API we want to finalize. |
|
I'd suggest fixing the documentation change and making the adjustments for compatibility, see here for instructions, so all the CI can complete and verify everything works |
769d06d to
5a729a8
Compare
78b99b6 to
843e536
Compare
843e536 to
19cd024
Compare
19cd024 to
3840ebf
Compare


Warning
This is now waiting on implementation approval to further proceed. Please leave any suggestions on the proposal linked below.
Closes godotengine/godot-proposals#14510.
Closes godotengine/godot-proposals#8155 _(a Copy button was implemented in the past).
Closes #57488 (Clear All button idea from @snailrhymer).
Closes godotengine/godot-proposals#8157 (implemented as a Clear All button).
This PR refactors the
EditorToasterinternals by introducing aToastclass that can be returned bypush_toast(). This allows us to then specifyActionsthat can be attached to this toast notification.These
Actionsare essentially buttons that can be assigned a Callable, which then allows you to implement a function call to do various things.This PR also adds a
Clear Allbutton as a nicety to the notification menu.--
Screen.Recording.2026-03-24.052849.mp4
Old Video for Reference
Screen.Recording.2026-03-21.044334.mp4