-
Notifications
You must be signed in to change notification settings - Fork 79
Update all dependencies across modules. Update workflows #2260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @gaby, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on a comprehensive update of the project's dependency ecosystem and Go language version. The primary goal is to modernize the codebase, enhance stability, and improve security by incorporating the latest upstream changes. This foundational work ensures that all modules are built on a current and well-maintained stack, paving the way for future development and reducing technical debt. Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This PR provides a repository-wide dependency update, including bumping the minimum Go version to 1.24 across most modules. This is a valuable maintenance task. I've pointed out one inconsistency in the Go version for the clickhouse module. The major version bump for surrealdb/surrealdb.go from v0.5.0 to v1.0.0 is also noted, which may introduce breaking changes. Otherwise, the changes look good.
|
Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. WalkthroughThe pull request adds context propagation to SurrealDB client API calls throughout the surrealdb.go file. Various internal method calls now explicitly pass Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro ⛔ Files ignored due to path filters (95)
📒 Files selected for processing (1)
🧰 Additional context used🧠 Learnings (4)📓 Common learnings📚 Learning: 2024-11-23T19:50:06.387ZApplied to files:
📚 Learning: 2024-11-08T04:10:42.990ZApplied to files:
📚 Learning: 2024-07-01T15:48:53.094ZApplied to files:
🪛 GitHub Actions: Tests SurrealDBsurrealdb/surrealdb.go[error] 77-77: Nil pointer dereference in Storage.Get during Test_Surrealdb_Delete. Panics at surrealdb.go:77. ⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (9)
🔇 Additional comments (2)
Tip 📝 Customizable high-level summaries are now available in beta!You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.
Example instruction:
Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@mdelapenya Is latest testcontainers working as expected? We have multiple workflows failing with same memory invalid failure. |
|
Ohh this is weird. It should work, we did not receive any issue about this. I can investigate it thought. Will come to this thread with my research |
@mdelapenya Have you found anything? @gaby Deleting alone will not suffice, as the benchmarks are not running because there is a real problem. |
|
Replaced by #2261 |

go mod tidyacross modules.Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.