Add fix-its for access level leaks #32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Always snapshot the original expanded source, even when the expansion includes diagnostics. (Moved `expansion` to be the first snapshot closure, not the last.) * Omit `expansion` if the original source didn't expand. (That is, the "expanded" source is identical to the source resulting from merely removing the macro attributes.) * Never automatically re-expand fixed source. (Require users to add a separate `assertMacro` statement, if fixed source isn't already tested elsewhere.) * Fix-its that can't be simulateously applied are now testable. * Changed the `fixes` string format to snapshot fixes individually. * Always snapshot the fixes, even when not all diagnostics have a fix-it. * Add an option to skip applying fix-its, e.g. when fix-it application is already covered by other tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
includes diagnostics. (Moved
expansionto be the first snapshotclosure, not the last.)
expansionif the original source didn't expand. (That is, the"expanded" source is identical to the source resulting from merely
removing the macro attributes.)
separate
assertMacrostatement, if fixed source isn't already testedelsewhere.)
fixesstring format to snapshot fixes individually.fix-it.
is already covered by other tests.