chore(types): moving types to the relevent packages and deleting types.go#669
Open
rshdhere wants to merge 1 commit intogoharbor:mainfrom
Open
chore(types): moving types to the relevent packages and deleting types.go#669rshdhere wants to merge 1 commit intogoharbor:mainfrom
rshdhere wants to merge 1 commit intogoharbor:mainfrom
Conversation
…s.go Signed-off-by: raashed <mohammedraashed10@gmail.com>
rshdhere
force-pushed
the
chore/move-types-to-relevent-packages
branch
from
a3d7f36 to
f7d21b2
Compare
Author
Author
|
@NucleoFusion a humble ping for this one |
Contributor
|
Please remove the binary from the commit |
NucleoFusion
suggested changes
Feb 24, 2026
Comment on lines
+16
to
+23
| package contextview | ||
|
|
||
| // ContextListView represents a context entry used in list/switch views. | ||
| type ContextListView struct { | ||
| Name string | ||
| Username string | ||
| Server string | ||
| } |
Contributor
There was a problem hiding this comment.
These can follow the existing structure and be included in the view.go itself.
Comment on lines
+14
to
+31
| package create | ||
|
|
||
| // RegistryCredential holds credentials for a registry provider in the view layer. | ||
| type RegistryCredential struct { | ||
| AccessKey string `json:"access_key,omitempty"` | ||
| Type string `json:"type,omitempty"` | ||
| AccessSecret string `json:"access_secret,omitempty"` | ||
| } | ||
|
|
||
| // CreateView is the interactive view model to create a registry. | ||
| type CreateView struct { | ||
| Name string | ||
| Type string | ||
| Description string | ||
| URL string | ||
| Credential RegistryCredential | ||
| Insecure bool | ||
| } |
Contributor
There was a problem hiding this comment.
These can follow the existing structure and be included in the view.go itself.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
solves #667
tested using dagger locally!