replace commands that use Run to use RunE#679
replace commands that use Run to use RunE#679bhavyaKhatri2703 wants to merge 9 commits intogoharbor:mainfrom
Conversation
Signed-off-by: bhavyakhatri2703 <khatribhavya2703@gmail.com>
24f5850 to
f13e913
Compare
|
@bhavyaKhatri2703 I see your commit messages. it's looking good, but follow ig dont need for this PR but do consider it in the upcoming PRs |
|
understood thanks for sharing @rshdhere |
Signed-off-by: bhavyakhatri2703 <khatribhavya2703@gmail.com>
Signed-off-by: Bhavya Khatri <khatribhavya2703@gmail.com>
Signed-off-by: bhavyakhatri2703 <khatribhavya2703@gmail.com>
|
can someone help me with these checks? |
Signed-off-by: bhavyakhatri2703 <khatribhavya2703@gmail.com>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #679 +/- ##
=========================================
- Coverage 10.99% 7.25% -3.74%
=========================================
Files 173 260 +87
Lines 8671 12909 +4238
=========================================
- Hits 953 936 -17
- Misses 7612 11865 +4253
- Partials 106 108 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
So right now, lint is failing. Which probably will be fixed if you run this |
|
Also, could you remove changes to the artifact directory? It seems to have some different format errors as well. |
Signed-off-by: bhavyakhatri2703 <khatribhavya2703@gmail.com>
done |
Signed-off-by: bhavyakhatri2703 <khatribhavya2703@gmail.com>
done |
bupd
left a comment
There was a problem hiding this comment.
@bhavyaKhatri2703 please resolve conflicts
Thanks for the contribution.
Signed-off-by: Bhavya Khatri <khatribhavya2703@gmail.com>
Signed-off-by: bhavyakhatri2703 <khatribhavya2703@gmail.com>
@bupd resolved, thanks I think lint is failing maybe because of issues in main |

fixes #675
replaced older commands from Run to RunE with errors being returned properly instead of jusing log.