fix: Update OCI registry publishing in release workflow#2294
Open
TerryHowe wants to merge 1 commit intogoharbor:mainfrom
Open
fix: Update OCI registry publishing in release workflow#2294TerryHowe wants to merge 1 commit intogoharbor:mainfrom
TerryHowe wants to merge 1 commit intogoharbor:mainfrom
Conversation
- Remove Docker Hub push that fails with authentication errors - Fix GHCR push to use organization path (ghcr.io/goharbor) instead of personal account - Properly authenticate using GITHUB_TOKEN which is available in Actions Fixes goharbor#2265 Signed-off-by: Developer <dev@example.com>
TerryHowe
force-pushed
the
fix/oci-registry-publishing
branch
from
c8fac53 to
c59accd
Compare
bupd
reviewed
Jan 7, 2026
There was a problem hiding this comment.
Thanks @TerryHowe
I believe we should fix the env vars rather than removing the dockerhub push.
looks like this has been failing for a past couple of months
|
@MinerYang thoughts ?? |
Author
|
Heya @bupd been a minute. I was thinking delivering charts to ghcr would almost certain work and that would unblock the problem. If someone really wants to deliver to docker.io, that could be a follow up. |
Collaborator
|
Sorry everyone, I was just back from a sick leave. Will take a look recently. |
Author
|
ping |
|
cc // @MinerYang |
cthtrifork
reviewed
Feb 20, 2026
| helm registry login registry-1.docker.io -u ${{ secrets.DOCKER_HUB_USERNAME }} -p ${{ secrets.DOCKER_HUB_PASSWORD }} | ||
| helm push ${{ env.PACKAGE_PATH }} oci://registry-1.docker.io/${{ secrets.DOCKER_HUB_USERNAME }} | ||
| helm registry login ghcr.io -u ${{ github.actor }} -p ${{ secrets.GITHUB_TOKEN }} | ||
| helm push ${{ env.PACKAGE_PATH }} oci://ghcr.io/${{ github.actor }} |
There was a problem hiding this comment.
Isn't oci://ghcr.io/${{ github.actor }} still wrong/brittle?
Suggested change
| helm push ${{ env.PACKAGE_PATH }} oci://ghcr.io/${{ github.actor }} | |
| helm push ${{ env.PACKAGE_PATH }} oci://ghcr.io/$GITHUB_REPOSITORY_OWNER |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the OCI registry publishing issue in the release workflow.
Changes
ghcr.io/goharbor) instead of personal account (ghcr.io/${{ github.actor }})GITHUB_TOKENwhich is available in GitHub ActionsFixes
Closes #2265