Skip to content

Fixes the broken pipe connection error with postgres. #15211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
wy65701436 merged 1 commit into from
Jul 23, 2021
Merged

Fixes the broken pipe connection error with postgres. #15211

wy65701436 merged 1 commit into from
Jul 23, 2021

Conversation

@Vad1mo
Copy link
Member

@Vad1mo Vad1mo commented Jun 26, 2021 •
edited
Loading

This should resolve #14856 or make it very unlikely to appear. We also did the same in the past with #4719

related to #15048

@codecov
Copy link

codecov bot commented Jun 26, 2021 •
edited
Loading

Codecov Report

Merging #15211 (ee0bc4a) into master (b789674) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15211      +/-   ##
==========================================
- Coverage   67.01%   66.98%   -0.04%     
==========================================
  Files         930      930              
  Lines       76422    76423       +1     
  Branches     2239     2239              
==========================================
- Hits        51216    51192      -24     
- Misses      21289    21317      +28     
+ Partials     3917     3914       -3
Flag Coverage Δ
unittests 66.98% <100.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/common/dao/pgsql.go 72.46% <100.00%> (+0.40%) ⬆️
src/controller/event/handler/auditlog/auditlog.go 11.11% <0.00%> (-44.45%) ⬇️
src/lib/cache/util.go 73.68% <0.00%> (-15.79%) ⬇️
src/controller/event/topic.go 1.80% <0.00%> (-7.21%) ⬇️
...es/vulnerability/vulnerability-config.component.ts 47.00% <0.00%> (-5.99%) ⬇️
.../project/member/add-member/add-member.component.ts 30.66% <0.00%> (-1.34%) ⬇️
src/common/utils/passports.go 89.74% <0.00%> (+5.12%) ⬆️

wy65701436
wy65701436 approved these changes Jul 23, 2021
View reviewed changes
Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wy65701436 wy65701436 merged commit 13d5e4a into goharbor:master Jul 23, 2021
wy65701436 pushed a commit to wy65701436/harbor that referenced this pull request Jul 29, 2021
@Vad1mo @wy65701436
fixes the broken pipe connection error with postgres. Similar as PR: g…
7269820 
…oharbor#4719 (goharbor#15211)

Signed-off-by: Vadim Bauer <vb@container-registry.com>

Co-authored-by: Vadim Bauer <vb@container-registry.com>
@wy65701436 wy65701436 mentioned this pull request Jul 29, 2021
Merged
wy65701436 pushed a commit to wy65701436/harbor that referenced this pull request Aug 9, 2021
@Vad1mo @wy65701436
fixes the broken pipe connection error with postgres. Similar as PR: g…
e01ab79 
…oharbor#4719 (goharbor#15211)

Signed-off-by: Vadim Bauer <vb@container-registry.com>

Co-authored-by: Vadim Bauer <vb@container-registry.com>
Signed-off-by: Wang Yan <wangyan@vmware.com>
wy65701436 added a commit that referenced this pull request Aug 9, 2021
@wy65701436 @Vad1mo
fixes the broken pipe connection error with postgres. Similar as PR: #…
0d003dc 
…4719 (#15211) (#15374)

Signed-off-by: Vadim Bauer <vb@container-registry.com>

Co-authored-by: Vadim Bauer <vb@container-registry.com>
Signed-off-by: Wang Yan <wangyan@vmware.com>

Co-authored-by: Vadim Bauer <1492007+Vad1mo@users.noreply.github.com>
Co-authored-by: Vadim Bauer <vb@container-registry.com>
@heww heww mentioned this pull request Aug 11, 2021
Closed
yunkunrao pushed a commit to yunkunrao/harbor that referenced this pull request Aug 19, 2021
@Vad1mo @yunkunrao
fixes the broken pipe connection error with postgres. Similar as PR: g…
70db382 
…oharbor#4719 (goharbor#15211)

Signed-off-by: Vadim Bauer <vb@container-registry.com>

Co-authored-by: Vadim Bauer <vb@container-registry.com>
danielzhanghl pushed a commit to nokia/harbor that referenced this pull request Aug 26, 2021
@wy65701436 @Vad1mo @danielzhanghl
fixes the broken pipe connection error with postgres. Similar as PR: g…
5b78b85 
…oharbor#4719 (goharbor#15211) (goharbor#15374)

Signed-off-by: Vadim Bauer <vb@container-registry.com>

Co-authored-by: Vadim Bauer <vb@container-registry.com>
Signed-off-by: Wang Yan <wangyan@vmware.com>

Co-authored-by: Vadim Bauer <1492007+Vad1mo@users.noreply.github.com>
Co-authored-by: Vadim Bauer <vb@container-registry.com>
@Vad1mo Vad1mo mentioned this pull request Sep 7, 2021
Closed
heww pushed a commit to heww/harbor that referenced this pull request Sep 8, 2021
@Vad1mo @heww
fixes the broken pipe connection error with postgres. Similar as PR: g…
6b078b3 
…oharbor#4719 (goharbor#15211)

Signed-off-by: Vadim Bauer <vb@container-registry.com>

Co-authored-by: Vadim Bauer <vb@container-registry.com>
@heww heww mentioned this pull request Sep 8, 2021
Merged
heww pushed a commit to heww/harbor that referenced this pull request Sep 8, 2021
@Vad1mo @heww
fixes the broken pipe connection error with postgres. Similar as PR: g…
a6c13f7 
…oharbor#4719 (goharbor#15211)

Signed-off-by: Vadim Bauer <vb@container-registry.com>
heww pushed a commit to heww/harbor that referenced this pull request Sep 8, 2021
@Vad1mo @heww
fixes the broken pipe connection error with postgres. Similar as PR: g…
1afd842 
…oharbor#4719 (goharbor#15211)

Signed-off-by: Vadim Bauer <vb@container-registry.com>
Signed-off-by: He Weiwei <hweiwei@vmware.com>
wy65701436 pushed a commit that referenced this pull request Sep 9, 2021
@heww @Vad1mo
fixes the broken pipe connection error with postgres. Similar as PR: #…
6931d73 
…4719 (#15211) (#15559)

Signed-off-by: Vadim Bauer <vb@container-registry.com>
Signed-off-by: He Weiwei <hweiwei@vmware.com>

Co-authored-by: Vadim Bauer <1492007+Vad1mo@users.noreply.github.com>
lindhe pushed a commit to lindhe/harbor that referenced this pull request Sep 22, 2021
@Vad1mo @lindhe
fixes the broken pipe connection error with postgres. Similar as PR: g…
7be4cde 
…oharbor#4719 (goharbor#15211)

Signed-off-by: Vadim Bauer <vb@container-registry.com>

Co-authored-by: Vadim Bauer <vb@container-registry.com>
Signed-off-by: Andreas Lindhé <andreas@lindhe.io>
prahaladdarkin pushed a commit to prahaladdarkin/harbor that referenced this pull request Nov 12, 2021
@Vad1mo @prahaladdarkin
fixes the broken pipe connection error with postgres. Similar as PR: g…
bec1106 
…oharbor#4719 (goharbor#15211)

Signed-off-by: Vadim Bauer <vb@container-registry.com>

Co-authored-by: Vadim Bauer <vb@container-registry.com>
prahaladdarkin pushed a commit to prahaladdarkin/harbor that referenced this pull request Mar 13, 2022
@Vad1mo @prahaladdarkin
fixes the broken pipe connection error with postgres. Similar as PR: g…
8c45bdf 
…oharbor#4719 (goharbor#15211)

Signed-off-by: Vadim Bauer <vb@container-registry.com>

Co-authored-by: Vadim Bauer <vb@container-registry.com>
@Vad1mo Vad1mo mentioned this pull request Sep 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wy65701436 wy65701436 wy65701436 approved these changes

@heww heww heww approved these changes

Assignees

@heww heww

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Harbor can't recover when the connection to the database drops.

3 participants

@Vad1mo @wy65701436 @heww