Remove unused SYNC_QUOTA from env.jinja template#22280
Merged
wy65701436 merged 2 commits intogoharbor:mainfrom Sep 1, 2025
Merged
Remove unused SYNC_QUOTA from env.jinja template#22280wy65701436 merged 2 commits intogoharbor:mainfrom
wy65701436 merged 2 commits intogoharbor:mainfrom
Conversation
`SYNC_QUOTA` is not used throughout the whole code. It looks like the feature using it was removed. Signed-off-by: Max Fröhlich <maxbruchmann@gmail.com>
Vad1mo
approved these changes
Aug 27, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #22280 +/- ##
===========================================
+ Coverage 45.36% 65.88% +20.51%
===========================================
Files 244 1072 +828
Lines 13333 115932 +102599
Branches 2719 2927 +208
===========================================
+ Hits 6049 76380 +70331
- Misses 6983 35319 +28336
- Partials 301 4233 +3932
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
AYDEV-FR
pushed a commit
to AYDEV-FR/harbor
that referenced
this pull request
Sep 19, 2025
Remove SYNC_QUOTA from env.jinja template `SYNC_QUOTA` is not used throughout the whole code. It looks like the feature using it was removed. Signed-off-by: Max Fröhlich <maxbruchmann@gmail.com> Co-authored-by: Wang Yan <wangyan@vmware.com>
AYDEV-FR
pushed a commit
to AYDEV-FR/harbor
that referenced
this pull request
Sep 19, 2025
Remove SYNC_QUOTA from env.jinja template `SYNC_QUOTA` is not used throughout the whole code. It looks like the feature using it was removed. Signed-off-by: Max Fröhlich <maxbruchmann@gmail.com> Co-authored-by: Wang Yan <wangyan@vmware.com>
AYDEV-FR
pushed a commit
to AYDEV-FR/harbor
that referenced
this pull request
Sep 19, 2025
Remove SYNC_QUOTA from env.jinja template `SYNC_QUOTA` is not used throughout the whole code. It looks like the feature using it was removed. Signed-off-by: Max Fröhlich <maxbruchmann@gmail.com> Co-authored-by: Wang Yan <wangyan@vmware.com>
OrlinVasilev
pushed a commit
to OrlinVasilev/harbor
that referenced
this pull request
Oct 29, 2025
Remove SYNC_QUOTA from env.jinja template `SYNC_QUOTA` is not used throughout the whole code. It looks like the feature using it was removed. Signed-off-by: Max Fröhlich <maxbruchmann@gmail.com> Co-authored-by: Wang Yan <wangyan@vmware.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SYNC_QUOTAis not used throughout the whole code.It looks like the feature using it was removed.
This PR removes the
SYNC_QUOTAline frommake/photon/prepare/templates/core/env.jinjaIssue being fixed
Fixes #22279
Please indicate you've done the following: