Skip to content

refactor the logic to init skip_audit_log_database#22493

Merged
wy65701436 merged 3 commits intogoharbor:mainfrom
wy65701436:refactor-skip-audit
Oct 24, 2025
Merged

refactor the logic to init skip_audit_log_database#22493
wy65701436 merged 3 commits intogoharbor:mainfrom
wy65701436:refactor-skip-audit

Conversation

@wy65701436
Copy link
Copy Markdown
Contributor

simplify the sql to set the value of skip_audit_log_database, any evidence of previous usage of db to record the audit, set it to false.

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

simplify the sql to set the value of skip_audit_log_database, any evidence of previous usage of db to record the audit, set it to false.

Signed-off-by: wang yan <yan-yw.wang@broadcom.com>
@wy65701436 wy65701436 requested a review from a team as a code owner October 24, 2025 06:54
@wy65701436 wy65701436 added the release-note/update Update or Fix label Oct 24, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.83%. Comparing base (c8c11b4) to head (2ab8323).
⚠️ Report is 581 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main   #22493       +/-   ##
===========================================
+ Coverage   45.36%   65.83%   +20.46%     
===========================================
  Files         244     1073      +829     
  Lines       13333   116106   +102773     
  Branches     2719     2931      +212     
===========================================
+ Hits         6049    76437    +70388     
- Misses       6983    35429    +28446     
- Partials      301     4240     +3939     
Flag Coverage Δ
unittests 65.83% <ø> (+20.46%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 987 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wy65701436 wy65701436 enabled auto-merge (squash) October 24, 2025 08:35
@wy65701436 wy65701436 merged commit c305a80 into goharbor:main Oct 24, 2025
17 of 18 checks passed
OrlinVasilev pushed a commit to OrlinVasilev/harbor that referenced this pull request Oct 29, 2025
simplify the sql to set the value of skip_audit_log_database, any evidence of previous usage of db to record the audit, set it to false.

Signed-off-by: wang yan <yan-yw.wang@broadcom.com>
Co-authored-by: wang yan <yan-yw.wang@broadcom.com>
vg006 pushed a commit to vg006/harbor that referenced this pull request Dec 4, 2025
simplify the sql to set the value of skip_audit_log_database, any evidence of previous usage of db to record the audit, set it to false.

Signed-off-by: wang yan <yan-yw.wang@broadcom.com>
Co-authored-by: wang yan <yan-yw.wang@broadcom.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-note/update Update or Fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants