disable land tag in the backend storage by wy65701436 · Pull Request #22507 · goharbor/harbor

wy65701436 · 2025-10-27T10:38:58Z

Thank you for contributing to Harbor!
disable land tag in the backend storage
According to the gc performance proposal, harbor will skip to write the tag file into the data storage since we already use the harbor database to manage the tag CRUD.
Proposal: goharbor/community#265

fixed #22405

Please indicate you've done the following:

Well Written Title and Summary of the PR
Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
Accepted the DCO. Commits without the DCO will delay acceptance.
Made sure tests are passing and test coverage is added if needed.
Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

codecov · 2025-10-27T10:45:16Z

Codecov Report

❌ Patch coverage is 75.00000% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 65.84%. Comparing base (c8c11b4) to head (b69eace).
⚠️ Report is 594 commits behind head on main.

Files with missing lines	Patch %	Lines
src/server/registry/manifest.go	75.00%	3 Missing and 2 partials ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##             main   #22507       +/-   ##
===========================================
+ Coverage   45.36%   65.84%   +20.47%     
===========================================
  Files         244     1073      +829     
  Lines       13333   116095   +102762     
  Branches     2719     2931      +212     
===========================================
+ Hits         6049    76440    +70391     
- Misses       6983    35418    +28435     
- Partials      301     4237     +3936

Flag	Coverage Δ
unittests	`65.84% <75.00%> (+20.47%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
src/server/registry/manifest.go	`68.15% <75.00%> (ø)`

... and 986 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

OrlinVasilev · 2025-10-27T10:50:54Z

@wy65701436 can you add some information in the PR

wy65701436 · 2025-10-27T11:00:40Z

@wy65701436 can you add some information in the PR

can you checkout the commit message?

OrlinVasilev · 2025-10-27T11:11:26Z

@wy65701436 updated the PR message as we use this one for the release notes.

chlins

lgtm

According to the gc performance proposal, harbor will skip to write the tag file into the data storage since we already use the harbor database to manage the tag CRUD. Proposal: goharbor/community#265 fixed goharbor#22405 Signed-off-by: wang yan <yan-yw.wang@broadcom.com>

stonezdj · 2025-11-06T07:01:38Z

 	// the reference is tag, get the digest from the response header
-	if _, err = digest.Parse(reference); err != nil {
+	if _, err := digest.Parse(reference); err != nil {
 		dgt = buffer.Header().Get("Docker-Content-Digest")


Should we have a warning message in the log when the dgst doesn't match the dgt?

According to the gc performance proposal, harbor will skip to write the tag file into the data storage since we already use the harbor database to manage the tag CRUD. Proposal: goharbor/community#265 fixed goharbor#22405 Signed-off-by: wang yan <yan-yw.wang@broadcom.com> Co-authored-by: wang yan <yan-yw.wang@broadcom.com> Signed-off-by: Ikram Aloui <ikramaloui145@gmail.com>

According to the gc performance proposal, harbor will skip to write the tag file into the data storage since we already use the harbor database to manage the tag CRUD. Proposal: goharbor/community#265 fixed goharbor#22405 Signed-off-by: wang yan <yan-yw.wang@broadcom.com> Co-authored-by: wang yan <yan-yw.wang@broadcom.com> Signed-off-by: Aloui-Ikram <ikramaloui145@gmail.com>

According to the gc performance proposal, harbor will skip to write the tag file into the data storage since we already use the harbor database to manage the tag CRUD. Proposal: goharbor/community#265 fixed goharbor#22405 Signed-off-by: wang yan <yan-yw.wang@broadcom.com> Co-authored-by: wang yan <yan-yw.wang@broadcom.com> Signed-off-by: Aloui-Ikram <ikramaloui145@gmail.com> Signed-off-by: ikram aloui <your-email@container-registry.com>

According to the gc performance proposal, harbor will skip to write the tag file into the data storage since we already use the harbor database to manage the tag CRUD. Proposal: goharbor/community#265 fixed goharbor#22405 Signed-off-by: wang yan <yan-yw.wang@broadcom.com> Co-authored-by: wang yan <yan-yw.wang@broadcom.com> Signed-off-by: Aloui-Ikram <ikramaloui145@gmail.com> Signed-off-by: ikram aloui <your-email@container-registry.com> Signed-off-by: Aloui-Ikram <ikram@container-registry.com>

According to the gc performance proposal, harbor will skip to write the tag file into the data storage since we already use the harbor database to manage the tag CRUD. Proposal: goharbor/community#265 fixed goharbor#22405 Signed-off-by: wang yan <yan-yw.wang@broadcom.com> Co-authored-by: wang yan <yan-yw.wang@broadcom.com> Signed-off-by: Aloui-Ikram <ikram@container-registry.com>

Signed-off-by: dulanting <dulanting@outlook.jp> Signed-off-by: Aloui-Ikram <ikram@container-registry.com> Add unit test for DeleteManifest method in TencentCR adapter (goharbor#22537) Added test case Signed-off-by: Anurag Ojha <aojharaj2004@gmail.com> Signed-off-by: Aloui-Ikram <ikram@container-registry.com> disable land tag in the backend storage (goharbor#22507) According to the gc performance proposal, harbor will skip to write the tag file into the data storage since we already use the harbor database to manage the tag CRUD. Proposal: goharbor/community#265 fixed goharbor#22405 Signed-off-by: wang yan <yan-yw.wang@broadcom.com> Co-authored-by: wang yan <yan-yw.wang@broadcom.com> Signed-off-by: Aloui-Ikram <ikram@container-registry.com>

According to the gc performance proposal, harbor will skip to write the tag file into the data storage since we already use the harbor database to manage the tag CRUD. Proposal: goharbor/community#265 fixed goharbor#22405 Signed-off-by: wang yan <yan-yw.wang@broadcom.com> Co-authored-by: wang yan <yan-yw.wang@broadcom.com>

microyahoo · 2026-01-15T07:55:39Z

hi @wy65701436, thanks for your contribution! I have two questions I'd like to consult:

I see this PR targets version 2.15. Why isn't it being merged into version 2.13 or 2.14?
If older versions of Harbor are upgraded to a version containing this PR, will there be any compatibility issues? Because there are also changes in the underlying storage.

wy65701436 requested a review from a team as a code owner October 27, 2025 10:38

github-actions Bot assigned chlins, OrlinVasilev and Vad1mo Oct 27, 2025

wy65701436 added target/2.15.0 area/gc labels Oct 27, 2025

github-project-automation Bot added this to GC Improvement Activities Oct 27, 2025

wy65701436 force-pushed the do-not-land-tag branch from d62abd3 to cb7f7e3 Compare October 27, 2025 10:41

wy65701436 added the release-note/new-feature New Harbor Feature label Oct 27, 2025

wy65701436 assigned stonezdj and MinerYang Oct 27, 2025

chlins approved these changes Oct 30, 2025

View reviewed changes

chlins force-pushed the do-not-land-tag branch from cb7f7e3 to f3111ea Compare October 30, 2025 10:42

stonezdj reviewed Nov 6, 2025

View reviewed changes

stonezdj approved these changes Nov 6, 2025

View reviewed changes

MinerYang approved these changes Nov 6, 2025

View reviewed changes

wy65701436 enabled auto-merge (squash) November 6, 2025 10:43

Merge branch 'main' into do-not-land-tag

b69eace

wy65701436 merged commit 95003aa into goharbor:main Nov 6, 2025
12 checks passed

github-project-automation Bot moved this to Completed in GC Improvement Activities Nov 6, 2025

wy65701436 mentioned this pull request Nov 20, 2025

[GC performance] The performance of v2 manifest deletion is not good in S3 environment #12948

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

disable land tag in the backend storage#22507

disable land tag in the backend storage#22507
wy65701436 merged 2 commits intogoharbor:mainfrom
wy65701436:do-not-land-tag

wy65701436 commented Oct 27, 2025 •

edited by OrlinVasilev

Loading

Uh oh!

codecov Bot commented Oct 27, 2025 •

edited

Loading

Uh oh!

OrlinVasilev commented Oct 27, 2025

Uh oh!

wy65701436 commented Oct 27, 2025

Uh oh!

OrlinVasilev commented Oct 27, 2025

Uh oh!

chlins left a comment

Uh oh!

stonezdj Nov 6, 2025 •

edited

Loading

Uh oh!

Uh oh!

microyahoo commented Jan 15, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Conversation

wy65701436 commented Oct 27, 2025 • edited by OrlinVasilev Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov Bot commented Oct 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

OrlinVasilev commented Oct 27, 2025

Uh oh!

wy65701436 commented Oct 27, 2025

Uh oh!

OrlinVasilev commented Oct 27, 2025

Uh oh!

chlins left a comment

Choose a reason for hiding this comment

Uh oh!

stonezdj Nov 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

microyahoo commented Jan 15, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

wy65701436 commented Oct 27, 2025 •

edited by OrlinVasilev

Loading

codecov Bot commented Oct 27, 2025 •

edited

Loading

stonezdj Nov 6, 2025 •

edited

Loading