Remove legacy switch from decodeFilters after UI bug #12579 fix#22510
Merged
OrlinVasilev merged 1 commit intogoharbor:mainfrom Oct 29, 2025
Merged
Conversation
intojhanurag
force-pushed
the
fix/p2p-remove-ui-bug-12579-switch
branch
from
dbced93 to
ca5d3f4
Compare
Contributor
Author
|
Hey @OrlinVasilev , It is ready for review. |
OrlinVasilev
approved these changes
Oct 28, 2025
Member
|
@bupd @AllForNothing @chlins take a look please! |
Signed-off-by: Anurag Ojha <aojharaj2004@gmail.com>
AllForNothing
force-pushed
the
fix/p2p-remove-ui-bug-12579-switch
branch
from
ca5d3f4 to
fe60183
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #22510 +/- ##
===========================================
+ Coverage 45.36% 65.84% +20.47%
===========================================
Files 244 1073 +829
Lines 13333 116095 +102762
Branches 2719 2931 +212
===========================================
+ Hits 6049 76442 +70393
- Misses 6983 35416 +28433
- Partials 301 4237 +3936
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
OrlinVasilev
pushed a commit
to OrlinVasilev/harbor
that referenced
this pull request
Oct 29, 2025
…ix (goharbor#22510) legacy switch from decodeFilters Signed-off-by: Anurag Ojha <aojharaj2004@gmail.com>
vg006
pushed a commit
to vg006/harbor
that referenced
this pull request
Dec 4, 2025
…ix (goharbor#22510) legacy switch from decodeFilters Signed-off-by: Anurag Ojha <aojharaj2004@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removed the old type conversion switch in
decodeFiltersthat handled inconsistentfilter value types due to UI bug #12579. The bug is now fixed, so manual conversion
is no longer needed.
Changes
strconvimport