Skip to content

docs/makefile-commands#22605

Merged
chlins merged 2 commits intogoharbor:mainfrom
intojhanurag:docs/makefile-commands
Jan 22, 2026
Merged

docs/makefile-commands#22605
chlins merged 2 commits intogoharbor:mainfrom
intojhanurag:docs/makefile-commands

Conversation

@intojhanurag
Copy link
Copy Markdown
Contributor

@intojhanurag intojhanurag commented Nov 30, 2025

This PR improves the developer workflow documentation by correcting Markdown syntax issues in the Makefile commands section. Each command now has a clear, beginner-friendly description explaining its purpose. Additionally, the "Running Tests" section has been clarified with instructions for Go and Web UI tests to help contributors validate their changes before submitting a PR.

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@intojhanurag
Copy link
Copy Markdown
Contributor Author

Hey @bupd ,
I noticed that the Harbor Makefile doesn't include a make test target.
Currently, the way to run tests locally seems to be:

go test ./...

@intojhanurag
Copy link
Copy Markdown
Contributor Author

Hey @MinerYang , It is ready for review . Please take a look if you have a moment.

Copy link
Copy Markdown
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@intojhanurag
Copy link
Copy Markdown
Contributor Author

Hey @wy65701436 , Label is missing . Please can you add, i have not access.

Copy link
Copy Markdown
Contributor

@bupd bupd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@wy65701436 wy65701436 added the release-note/update Update or Fix label Dec 4, 2025
Comment thread CONTRIBUTING.md Outdated
Comment thread CONTRIBUTING.md Outdated
Signed-off-by: Anurag Ojha <aojharaj2004@gmail.com>
@intojhanurag intojhanurag force-pushed the docs/makefile-commands branch from a0d74c1 to cf91ca5 Compare January 22, 2026 04:53
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 22, 2026

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 46.63%. Comparing base (c8c11b4) to head (cf91ca5).
⚠️ Report is 626 commits behind head on main.

Files with missing lines Patch % Lines
...te-edit-endpoint/create-edit-endpoint.component.ts 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #22605      +/-   ##
==========================================
+ Coverage   45.36%   46.63%   +1.26%     
==========================================
  Files         244      252       +8     
  Lines       13333    14274     +941     
  Branches     2719     2931     +212     
==========================================
+ Hits         6049     6657     +608     
- Misses       6983     7259     +276     
- Partials      301      358      +57     
Flag Coverage Δ
unittests 46.63% <0.00%> (+1.26%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/portal/src/app/shared/services/interface.ts 72.72% <ø> (ø)
...te-edit-endpoint/create-edit-endpoint.component.ts 37.86% <0.00%> (-0.19%) ⬇️

... and 177 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@intojhanurag intojhanurag force-pushed the docs/makefile-commands branch from cf91ca5 to 1f5541a Compare January 22, 2026 05:06
Signed-off-by: intojhanurag <aojharaj2004@gmail.com>
@intojhanurag intojhanurag force-pushed the docs/makefile-commands branch from dc38c0f to 6c30d78 Compare January 22, 2026 05:08
@intojhanurag
Copy link
Copy Markdown
Contributor Author

Hey @chlins , thanks for the review . I applied your changes.

Copy link
Copy Markdown
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chlins chlins merged commit 2a29db9 into goharbor:main Jan 22, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-note/update Update or Fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants