Skip to content

Replace pull-through cache with proxy cache#22766

Merged
wy65701436 merged 3 commits intogoharbor:mainfrom
stonezdj:26jan22_remove_pull_through
Jan 28, 2026
Merged

Replace pull-through cache with proxy cache#22766
wy65701436 merged 3 commits intogoharbor:mainfrom
stonezdj:26jan22_remove_pull_through

Conversation

@stonezdj
Copy link
Copy Markdown
Contributor

fixes #22611

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@stonezdj stonezdj requested a review from a team as a code owner January 22, 2026 08:51
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.95%. Comparing base (c8c11b4) to head (00229f7).
⚠️ Report is 650 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main   #22766       +/-   ##
===========================================
+ Coverage   45.36%   65.95%   +20.58%     
===========================================
  Files         244     1074      +830     
  Lines       13333   116380   +103047     
  Branches     2719     2937      +218     
===========================================
+ Hits         6049    76760    +70711     
- Misses       6983    35374    +28391     
- Partials      301     4246     +3945     
Flag Coverage Δ
unittests 65.95% <ø> (+20.58%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 989 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@stonezdj stonezdj assigned wy65701436 and stonezdj and unassigned wy65701436 and MinerYang Jan 22, 2026
@stonezdj stonezdj force-pushed the 26jan22_remove_pull_through branch from 71bb86c to fe1e78a Compare January 22, 2026 08:57
@stonezdj stonezdj added the release-note/update Update or Fix label Jan 22, 2026
Copy link
Copy Markdown
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Copy Markdown
Contributor

@MinerYang MinerYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wy65701436 wy65701436 enabled auto-merge (squash) January 26, 2026 06:43
  fixes goharbor#22611

Signed-off-by: stonezdj <stonezdj@gmail.com>
@stonezdj stonezdj force-pushed the 26jan22_remove_pull_through branch from fe1e78a to ebf77a8 Compare January 26, 2026 07:32
Copy link
Copy Markdown
Contributor

@bupd bupd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stonezdj - can you also update all the other languages too.

wang yan and others added 2 commits January 28, 2026 14:34
Resolve the comments of goharbor#22766 (review)

Signed-off-by: wang yan <yan-yw.wang@broadcom.com>
@wy65701436
Copy link
Copy Markdown
Contributor

@stonezdj - can you also update all the other languages too.

I've updated all the other languages with the latest commit.

@wy65701436 wy65701436 merged commit ece5031 into goharbor:main Jan 28, 2026
12 checks passed
sias32 pushed a commit to sias32/harbor that referenced this pull request Feb 1, 2026
fixes goharbor#22611

Signed-off-by: stonezdj <stonezdj@gmail.com>
sias32 pushed a commit to sias32/harbor that referenced this pull request Feb 2, 2026
fixes goharbor#22611

Signed-off-by: stonezdj <stonezdj@gmail.com>
sias32 pushed a commit to sias32/harbor that referenced this pull request Feb 5, 2026
fixes goharbor#22611

Signed-off-by: stonezdj <stonezdj@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Harbor proxy cache is not pull-through cache - fix description on UI.

6 participants