feat: add notification_enable to harbor_config_system resource#568
Open
listellm wants to merge 2 commits intogoharbor:mainfrom
Open
feat: add notification_enable to harbor_config_system resource#568listellm wants to merge 2 commits intogoharbor:mainfrom
listellm wants to merge 2 commits intogoharbor:mainfrom
Conversation
listellm
force-pushed
the
feat/add-notification-enable
branch
2 times, most recently
from
d78226c to
6759e7b
Compare
✨ Add support for notification_enable system configuration 🔧 Expose global webhook/notification feature gate in Terraform 📝 Enable declarative management of notification settings Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> Signed-off-by: Listell McLean <listell.mclean@e-star.com>
listellm
force-pushed
the
feat/add-notification-enable
branch
from
6759e7b to
fca8b53
Compare
Contributor
|
@listellm thanks for the PR, could you please update the documentation ? |
Author
Done — documentation has been updated in the latest commit. |
Contributor
|
I suppose you forgot to push, I can't see the documentation |
Author
now pushed |
Contributor
|
thank you ! |
- Add `notification_enable` to example usage block - Document attribute in Optional schema section - Note webhook silencing behaviour when disabled Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Listell McLean <listell.mclean@e-star.com>
listellm
force-pushed
the
feat/add-notification-enable
branch
from
074e630 to
879563d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for the
notification_enablesystem configuration parameter to theharbor_config_systemresource. This parameter controls the global webhook/notification feature gate in Harbor.Changes
✨ Added
notification_enablefield to:models/config.go- ConfigBodySystemPost and ConfigBodyResponse structsprovider/resource_config_system.go- Schema attribute and read mappingclient/config.go- Body construction in GetConfigSystem()Motivation
The
notification_enableparameter is a critical setting for anyone usingharbor_project_webhookresources. Whennotification_enableisfalse, all project-level webhook policies are silently ignored. This PR enables declarative management of this setting via Terraform.Testing
Related Issue
Closes #567
🤖 Generated with Claude Code