Skip to content

Set golangci-lint to 1.54.2 (latest is broken) #1046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dhui merged 2 commits into from
Apr 16, 2024
Merged

Set golangci-lint to 1.54.2 (latest is broken) #1046

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d7565af
Set golangci-lint to 1.54.2 (latest is broken)
rockdaboot Mar 8, 2024
5d8ff45
Testing golangci-lint latest (1.57.1)
rockdaboot Mar 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,9 @@ jobs:
go-version: "1.21.x"
- uses: actions/checkout@v4
- name: golangci-lint
uses: golangci/golangci-lint-action@v3
uses: golangci/golangci-lint-action@v4
with:
version: latest
version: v1.54.2
Copy link
Copy Markdown
Member

@dhui dhui Mar 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why 1.54.2 instead of 1.57.1 which is the latest version. Per their docs, pinning the version is a good idea for reproducibility.

Copy link
Copy Markdown
Contributor Author

@rockdaboot rockdaboot Mar 25, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The latest version as of submitting this PR (two weeks ago) was 1.56.2 which was known to be broken (e.g. the CI of migrate failed).
I am happy to test 1.57.1 when back at my dev machine.

Copy link
Copy Markdown
Contributor Author

@rockdaboot rockdaboot Mar 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, reverted to "latest". So this PR currently boils down to increasing the golangci-lint-action to v4. Feel free to merge or close :)


test:
runs-on: ubuntu-latest
Expand Down