Skip to content

add tests for scylladb. add scylladb to docs#947

Merged
dhui merged 4 commits into
golang-migrate:masterfrom
mkorolyov:scylladb_support
Dec 20, 2023
Merged

add tests for scylladb. add scylladb to docs#947
dhui merged 4 commits into
golang-migrate:masterfrom
mkorolyov:scylladb_support

Conversation

@mkorolyov

Copy link
Copy Markdown
Contributor

Migrate works with Cassandra so it should work with ScyllaDB too as it is a drop-in replacement.

I've checked this and all works fine. Added Cassandra like tests for ScyllaDB and updated docs.

@mkorolyov

Copy link
Copy Markdown
Contributor Author

@Fontinalis Hey, could you pls take a look into this one?

@guy9

guy9 commented Jul 11, 2023

Copy link
Copy Markdown

I'm also interested in this

@mixellent

Copy link
Copy Markdown

+1

1 similar comment
@annastuchlik

Copy link
Copy Markdown

+1

@coveralls

coveralls commented Jul 11, 2023

Copy link
Copy Markdown

Coverage Status

coverage: 59.051%. remained the same
when pulling 1d1cd48 on mkorolyov:scylladb_support
into 90c5015 on golang-migrate:master.

Fontinalis
Fontinalis previously approved these changes Jul 11, 2023

@Fontinalis Fontinalis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you for the contribution!

@dhui dhui merged commit eb64ffa into golang-migrate:master Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants