app/appengine: set GO111MODULE=on for deploy #23
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying in GOPATH mode is not supported, so explicitly specify GO111MODULE=on to use module mode regardless of local setup. Fixes golang/go#34107
|
This PR (HEAD: 93f780c) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/build/+/193597 to see it. Tip: You can toggle comments from me using the |
|
Message from Andrew Bonventre: Patch Set 1: Code-Review+2 Please don’t reply on this GitHub thread. Visit golang.org/cl/193597. |
|
Message from Alexander Rakoczy: Patch Set 1: Code-Review+2 Please don’t reply on this GitHub thread. Visit golang.org/cl/193597. |
gopherbot
pushed a commit
that referenced
this pull request
Sep 5, 2019
Deploying in GOPATH mode is not supported, so explicitly specify GO111MODULE=on to use module mode regardless of local setup. Fixes golang/go#34107 Change-Id: I5bc2518c4cd4c329eea65684fec96aae5b0bf808 GitHub-Last-Rev: 93f780c GitHub-Pull-Request: #23 Reviewed-on: https://go-review.googlesource.com/c/build/+/193597 Reviewed-by: Andrew Bonventre <[email protected]> Reviewed-by: Alexander Rakoczy <[email protected]>
|
This PR is being closed because golang.org/cl/193597 has been merged. |
codebien
pushed a commit
to codebien/build
that referenced
this pull request
Nov 13, 2019
Deploying in GOPATH mode is not supported, so explicitly specify GO111MODULE=on to use module mode regardless of local setup. Fixes golang/go#34107 Change-Id: I5bc2518c4cd4c329eea65684fec96aae5b0bf808 GitHub-Last-Rev: 93f780c GitHub-Pull-Request: golang#23 Reviewed-on: https://go-review.googlesource.com/c/build/+/193597 Reviewed-by: Andrew Bonventre <[email protected]> Reviewed-by: Alexander Rakoczy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deploying in GOPATH mode is not supported, so explicitly specify
GO111MODULE=on to use module mode regardless of local setup.
Fixes golang/go#34107