-
Notifications
You must be signed in to change notification settings - Fork 2k
crypto/ocsp: add support for Ed25519 signatures in OCSP responses #319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
This PR (HEAD: 41a68e2) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/crypto/+/665955. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/665955. |
Message from Gopher Robot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/665955. |
41a68e2
to
fdf63c3
Compare
This PR (HEAD: fdf63c3) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/crypto/+/665955. Important tips:
|
fdf63c3
to
98842f9
Compare
This PR (HEAD: 98842f9) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/crypto/+/665955. Important tips:
|
Message from david bensoussan: Patch Set 5: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/665955. |
This PR is necessary to work with the ocsp server in cfssl.
See additional PR there cloudflare/cfssl#1420
This PR adds support for the EdDSA Ed25519 signature algorithm
to the OCSP response signing logic. This allows cfssl to
generate OCSP responses using Ed25519 keys, in compliance
with RFC 8410.
Key Changes:
appropriate pkix.AlgorithmIdentifier, and avoid setting Parameters
(as required by RFC 8410)
crypto.Hash(0) is used (i.e., for Ed25519), passing the raw DER
directly to priv.Sign
Motivation:
Ed25519 is widely adopted due to its performance, small key size, and
resistance to common cryptographic attacks. Supporting it in OCSP
flows is critical for enabling modern PKI infrastructures that
prefer or require Ed25519-based certificates and responders.
Compatibility
This change is backward-compatible. The existing RSA and ECDSA flows
remain untouched. Ed25519 is only engaged if the responder key is of
type ed25519.PublicKey and the SignatureAlgorithm is x509.PureEd25519.