WIP: Bugfix 76345 acme client sending jwk to kid expected endpoints#329
Draft
fangpenlin wants to merge 2 commits intogolang:masterfrom
Draft
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
fangpenlin
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing the bug golang/go#76345 by porting our changes in the downstream cert-manager PR cert-manager/cert-manager#8262
I know the contribution guide line mentioned it would be great to have some discussion first before working on fixing the issue. However, since the code changes are already proposed in the downstream cert-manager forked, and I realized this is actually a bug from the upstream. As the code change is already available, so I would like to port the PR here to open the discussion before I even start jumping the hoops of contributor agreements and onboarding process. Please let me know what do you think about the changes (or maybe I should open the discussion somewhere else?) 🙏