Skip to content
This repository was archived by the owner on Sep 9, 2020. It is now read-only.

Re-enable TestRemove on windows once it works reliably #301

Closed
sdboyer opened this issue Mar 7, 2017 · 1 comment
Closed

Re-enable TestRemove on windows once it works reliably #301

sdboyer opened this issue Mar 7, 2017 · 1 comment
Labels

Comments

@sdboyer
Copy link
Member

sdboyer commented Mar 7, 2017

We've got intermittent failures on windows builds due to how gps handles its git invocations (@tro3 tracked it down here - #214 (comment)) - but only on TestRemove. I've disabled the test on windows for now; this issue is to remind us that we need to re-enable the test once gps fixes its underlying issue.

@sdboyer sdboyer added the bug label Mar 7, 2017
sdboyer added a commit that referenced this issue Mar 7, 2017
These intermittent failures are just ruining CI on other PRs. #301 is
open as a reminder to re-renable this test once the underlying problem
in gps is fixed.
@sdboyer
Copy link
Member Author

sdboyer commented Apr 28, 2017

Closing this, should no longer be an issue.

@sdboyer sdboyer closed this as completed Apr 28, 2017
ibrasho pushed a commit to ibrasho-forks/dep that referenced this issue May 10, 2017
These intermittent failures are just ruining CI on other PRs. golang#301 is
open as a reminder to re-renable this test once the underlying problem
in gps is fixed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant