dep/gps/pkgtree: test failure

[dcheney-atlassian]

deadwood(~) % go test github.com/golang/dep/gps/pkgtree
--- FAIL: TestListPackages (0.00s)
    --- FAIL: TestListPackages/malformed_go_file (0.00s)
        pkgtree_test.go:1320: Did not get expected PackageOrErrs:
                        (GOT): pkgtree.PackageTree{ImportRoot:"bad", Packages:map[string]pkgtree.PackageOrErr{"bad":pkgtree.PackageOrErr{P:pkgtree.Package{Name:"", ImportPath:"", CommentPath:"", Imports:[]string(nil), TestImports:[]string(nil)}, Err:scanner.ErrorList{(*scanner.Error)(0xc420183640)}}}}
                        (WNT): pkgtree.PackageTree{ImportRoot:"bad", Packages:map[string]pkgtree.PackageOrErr{"bad":pkgtree.PackageOrErr{P:pkgtree.Package{Name:"", ImportPath:"", CommentPath:"", Imports:[]string(nil), TestImports:[]string(nil)}, Err:scanner.ErrorList{(*scanner.Error)(0xc420182140)}}}}
FAIL
FAIL    github.com/golang/dep/gps/pkgtree       0.007s

% go version
go version devel +507f4d5 Fri May 5 01:00:11 2017 +0000 linux/amd64

[sdboyer]

yeah ty - i just noticed this, and am super-confused about how it snuck by our CI

[krisnova]

good point

I know we had to work on other tests in this package to get gps into dep.. hrmmm 🤔

Is this intermittent or constant? Just curious 😁

[krisnova]

Ah just kidding - Sam already found it 😁

[sdboyer]

it's still super, super weird that it made it past CI, as this was a consistent error owing to...ugh...a super brittle test that got cranky when the license header changed file offsets. it should've been complaining immediately.

makes me not trust travis. 😢

[davecheney]

makes me not trust travis.

The test passes because the test sets an environment variable to skip the test https://travis-ci.org/golang/dep

…

On Fri, May 5, 2017 at 2:28 PM, sam boyer ***@***.***> wrote: it's still super, super weird that it made it past CI, as this was a consistent error owing to...ugh...a super brittle test that got cranky when the license header changed file offsets. it should've been complaining immediately. makes me not trust travis. 😢 — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#520 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAcA_0E4tgeKl8ys1gaykjDGVHrWFTnks5r2qWCgaJpZM4NRaeJ> .

[sdboyer]

...lol, it was right in front of me and i didn't read it. maybe it's time to go to sleep 😄